Move capture code closer to its equivalent use case #7608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7608 +/- ##
==========================================
- Coverage 99.68% 99.60% -0.08%
==========================================
Files 531 530 -1
Lines 51979 52040 +61
==========================================
+ Hits 51815 51835 +20
- Misses 164 205 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrijapau
reviewed
Jun 5, 2025
andrijapau
requested changes
Jun 5, 2025
Co-authored-by: Andrija Paurevic <[email protected]>
andrijapau
reviewed
Jun 6, 2025
| @@ -204,21 +201,19 @@ def create_measurement_wires_primitive( | |||
| if not has_jax: | |||
| return None | |||
|
|
|||
| from .custom_primitives import QmlPrimitive # pylint: disable=import-outside-toplevel | |||
| from ..capture.custom_primitives import QmlPrimitive # pylint: disable=import-outside-toplevel | |||
There was a problem hiding this comment.
Will this cause any potential risk?
JerryChen97
approved these changes
Jun 6, 2025
| @@ -204,21 +201,19 @@ def create_measurement_wires_primitive( | |||
| if not has_jax: | |||
| return None | |||
|
|
|||
| from .custom_primitives import QmlPrimitive # pylint: disable=import-outside-toplevel | |||
| from ..capture.custom_primitives import QmlPrimitive # pylint: disable=import-outside-toplevel | |||
There was a problem hiding this comment.
Will this cause any potential risk?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When we first started, I tried to keep program cpature code isolated so it wouldn't cause confusion and complexity during standard developement. Now it's much more fleshed out, and instead it causes problems with module dependencies.
Description of the Change:
Moves operator, measurement, and gradient capture code closer to the code that it captures.
Benefits:
Clearer chain of dependencies.
Possible Drawbacks:
As program capture is still fairly experimental, I'm not concerned about moving things breaking anything.
Related GitHub Issues:
[sc-92605]