Skip to content

[WIP] Adjust get_best_diff_method to apply user transforms correctly #7592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: shots-decoupling/helpers
Choose a base branch
from

Conversation

JerryChen97
Copy link
Contributor

@JerryChen97 JerryChen97 commented Jun 3, 2025

Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-92511]

@JerryChen97 JerryChen97 self-assigned this Jun 3, 2025
Copy link
Contributor

github-actions bot commented Jun 3, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@JerryChen97 JerryChen97 marked this pull request as ready for review June 4, 2025 18:35
@JerryChen97 JerryChen97 changed the title Adjust get_best_diff_method to apply user transforms correctly [WIP] Adjust get_best_diff_method to apply user transforms correctly Jun 4, 2025
@JerryChen97 JerryChen97 added the WIP 🚧 Work-in-progress label Jun 4, 2025
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (f001575) to head (591f693).
Report is 3 commits behind head on shots-decoupling/helpers.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           shots-decoupling/helpers    #7592   +/-   ##
=========================================================
  Coverage                     99.68%   99.68%           
=========================================================
  Files                           532      532           
  Lines                         51784    51784           
=========================================================
  Hits                          51620    51620           
  Misses                          164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JerryChen97
Copy link
Contributor Author

Emmmmm i didn't find a direct call within our own codebase... Maybe need to examine what current test suites are expecting and create some new tests if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP 🚧 Work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant