-
Notifications
You must be signed in to change notification settings - Fork 672
Algebric prerequisites for Clifford+T decompositions #7588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7588 +/- ##
========================================
Coverage 99.67% 99.67%
========================================
Files 532 534 +2
Lines 52374 52732 +358
========================================
+ Hits 52204 52562 +358
Misses 170 170 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d3c14a3
to
1173b34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some comments for the rings file. I'll take a look at normal forms later today.
…o normal-form-decomp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, mostly just questions about how the algorithm works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more minor comments. Should be able to approve when they are addressed.
return self * self.conj() | ||
|
||
def parity(self: ZOmega) -> int: | ||
"""Return the parity for conversion to ZSqrtTwo.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe give an example of the conversion for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Context: This introduces and provides some algebraic prerequisites necessary for number-theoretic Clifford-T decomposition methods.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: