-
Notifications
You must be signed in to change notification settings - Fork 2
Allow to pass options to cargo install
#23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi! Yes, this seems appropriate. I'll look into it some time soon. I already have the plan to add a good part of I therefore see two complementary things that should be done:
|
Start of #23. Signed-off-by: Paul Mabileau <[email protected]>
As part of #23. Signed-off-by: Paul Mabileau <[email protected]>
As part of #23. Signed-off-by: Paul Mabileau <[email protected]>
As part of #23. Signed-off-by: Paul Mabileau <[email protected]>
As part of #23. Signed-off-by: Paul Mabileau <[email protected]>
As part of #23. Signed-off-by: Paul Mabileau <[email protected]>
Actually closes #23. Signed-off-by: Paul Mabileau <[email protected]>
Hey @xduugu, sorry for the delay! I have now implemented both options in the mentioned commits. Does it work for what you wanted? You can test it by installing the project with |
This is now part of v0.7.0. Feel free to open a new issue in case there is something that does not work as expected. |
@PaulDance, thanks a lot! It works as expected. When testing the new functionality, I noticed that the example configuration in the README is not valid TOML syntax. Apparently, inline tables must not include newlines. |
Good!
Indeed, I did the change while not even thinking about that. I'll change it to be proper TOML. Thanks for the heads-up 🙂 |
As mentioned in #23, the TOML was invalid in multiple ways. It should now be a bit better. Signed-off-by: Paul Mabileau <[email protected]>
As mentioned in #23, the TOML was invalid in multiple ways. It should now be a bit better. Same done for the informal spec. Signed-off-by: Paul Mabileau <[email protected]>
Description
It is currently not possible to update gitui with cargo-liner, because cargo-liner does not use
cargo install
's--locked
option when installing packages and there is no possibility to set this option without changing the code. Please provide a way to pass options tocargo install
to fix this issue.Preferred solution
The easiest solution probably would be to allow setting
cargo install
options via environment variable. For example, cargo-update use an environment variableCARGO_INSTALL_OPTS
for that.The text was updated successfully, but these errors were encountered: