Use Path.GetTempPath to ensure IO happens Windows/Linux temp folder
#7346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (`TEMPDIR,`TEMP,`TMP`). On Linux this almost always is a `tmpfs` RAM drive and much faster.
|
I have a vague memory this was debated in the past and we concluded we don't want by default fill a directory outside the running directory because fulling up the users temp drives is not really great and the benefit of having it in the app domain directory is that you can clean things with all the other temporary "build" artifacts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Path.GetTempPathto ensure IO happens Windows/Linux temp folders (TEMPDIR,TEMP,TMP). On Linux this almost always is atmpfsRAM drive and much faster.During testing of the following PR I noticed
tmpfswasn't used: