Learning transport throws exceptions when running multiple endpoint instances #7324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/NServiceBus.Core/Transports/Learning/DirectoryBasedTransaction.cs
Outdated
Show resolved
Hide resolved
| return true; | ||
| } | ||
|
|
||
| Directory.Delete(transactionDir, true); |
There was a problem hiding this comment.
The rollback already does a delete. Is the rollback not consistently called and we have to do extra cleanup here?
There was a problem hiding this comment.
The Rollback method is only called when BeginTransaction returns true
danielmarbach
approved these changes
Apr 8, 2025
…tion.cs Co-authored-by: Daniel Marbach <[email protected]>
andreasohlund
approved these changes
Apr 8, 2025
SzymonPobiega
added a commit
that referenced
this pull request
Apr 8, 2025
* AsyncFile.Move returns true only if the file was read (i.e. exists and not locked) * Clean up the .pending directory if unable to move and unlock the file Co-authored-by: Daniel Marbach <[email protected]>
andreasohlund
changed the title
danielmarbach
added a commit
that referenced
this pull request
Apr 9, 2025
* AsyncFile.Move returns true only if the file was read (i.e. exists and not locked) * Clean up the .pending directory if unable to move and unlock the file Co-authored-by: Daniel Marbach <[email protected]>
SzymonPobiega
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptoms
When scaled out, endpoints using learning transport throw exceptions when another instance consumes a message
Who's affected
Only Monitoring Demo's Sales endpoint is affected
Details of the fix
.pendingtransaction folder only returnstrueif file exists and is not locked (and not just when all attempts have been used)BeginTransactionremoves the.pendingfolder if fails to begin the transaction