Issue 128 #200
Merged
Issue 128 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a par2 set with parpar since par2cmdline normally should not allow empty files to be included in the parset. This test is currently failing because the test-a.data file is empty. ``` Repair is required. 1 file(s) exist but are damaged. 10 file(s) are ok. You have 1029 out of 1029 data blocks available. You have 52 recovery blocks available. Repair is possible. You have an excess of 52 recovery blocks. None of the recovery blocks will be used for the repair. Wrote 0 bytes to diska Verifying repaired files: Target: "test-a.data" - empty. Repair Failed. ``` Tickets: #128 Signed-off-by: BlackEagle <[email protected]>
This is a workaround for empty files in a parset breaking repair. The empty file will always land in the unverifiable sourcefile list. But we can match it lateron. Currently I don't think we can get it in the verifiedsourcefiles because there are a ton of guardrails against loading 0 byte files. It also looks on first glance this workaround is needed to be able to verify parfiles created with other tools not skipping on 0 byte files. Tickets: #128 Signed-off-by: BlackEagle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test + workaround for #128
Closes #128