Skip to content

adds Add/Remove Component/Element to VV #29339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

warriorstar-orion
Copy link
Contributor

What Does This PR Do

This PR adds the ability to Add, Remove, and Mass Remove elements and components from datums in the VV menu. Cribbed heavily from tgstation/tgstation#45929.

Why It's Good For The Game

Good for testing, good for admin shenanigans.

Images of changes

bandicam.2025-05-15.16-24-49-293.mp4

Testing

Used menu options, ensured test components/elements work as expected.

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@warriorstar-orion warriorstar-orion added the Administration This PR relates to ingame administration features label May 15, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label May 15, 2025
for(var/to_delete in components_actual)
qdel(to_delete)

message_admins("<span class='notice'>[key_name_admin(usr)] has [mass_remove? "mass" : ""] removed [path] component from [mass_remove? target.type : key_name_admin(target)].</span>")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message_admins("<span class='notice'>[key_name_admin(usr)] has [mass_remove? "mass" : ""] removed [path] component from [mass_remove? target.type : key_name_admin(target)].</span>")
message_admins("<span class='notice'>[key_name_admin(usr)] has [mass_remove ? "mass" : ""] removed [path] component from [mass_remove ? target.type : key_name_admin(target)].</span>")

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Administration This PR relates to ingame administration features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants