Skip to content

Adds abandoned server rooms to station maints #28972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

PollardTheDragon
Copy link
Contributor

@PollardTheDragon PollardTheDragon commented Apr 11, 2025

What Does This PR Do

Adds some abandoned server rooms to station maints areas. They come stocked with an unbuilt APC, two mostly-build processing nodes, one fully built network node, some basic atmos, and a single maints loot spawner.

Why It's Good For The Game

Having some examples of how to set up server nodes properly, while also having a few pre-existing ones to remind crew that they exist, is a good way to further integrate the system.

Images of changes

Cerestation
image

BoxStation
image

Metastation
image

EmeraldStation
image

DeltaStation
image

Testing

Loaded map, new area was there.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image


Changelog

🆑
add: Added new abandoned server rooms to maints of each station
/:cl:

@Fordoxia
Copy link
Contributor

Fordoxia commented Apr 11, 2025

The rooms should be equipped with fire alarms and air alarms, especially as they have active vents (and a scrubber in the case of Delta).

Also at least one light bulb probably.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map Sprites This PR modifies the game sprites labels Apr 12, 2025
@PollardTheDragon
Copy link
Contributor Author

The rooms should be equipped with fire alarms and air alarms, especially as they have active vents (and a scrubber in the case of Delta).

Also at least one light bulb probably.

They each have a light bulb, but I can add the other things.

@Fordoxia
Copy link
Contributor

The rooms should be equipped with fire alarms and air alarms, especially as they have active vents (and a scrubber in the case of Delta).
Also at least one light bulb probably.

They each have a light bulb, but I can add the other things.

Ah gotcha, I didn't notice the light tube, it blended in with the table and I wasn't expecting it to be a tube, being in maint.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Apr 12, 2025
@Stealthii
Copy link
Contributor

The rooms should be equipped with fire alarms and air alarms, especially as they have active vents (and a scrubber in the case of Delta).

Also at least one light bulb probably.

I'd argue for fire alarm frames over functional ones, mainly as a nod to them being abandoned, and also to encourage some new engineers to figure out how to build them (and that they even exist)

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Apr 14, 2025
@github-actions github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Apr 20, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Apr 30, 2025
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label May 4, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label May 17, 2025
Copy link
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like on Meta, you had the room originally in the south but moved it to the north, and didn't put it back the way it was, could you isolate your changes to the new room in the north?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Map Edit This PR will modify a map Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants