Skip to content

Changelings now update their flavor text upon transforming. Updates DNA to include flavor text. #26094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

Spaghetti-bit
Copy link
Contributor

What Does This PR Do

Fixes #3352

Adds flavor text to DNA.
Transforming through changeling transform updates flavor text.
Polymorph flavor text stays the same as the original as poly morph doesn't copy over all DNA and only changes U.I. stuff.

Autodocs some of the DNA stuff for easier readability.

Why It's Good For The Game

This was originally an oversight (8 years old...) and allowed people to metagame. If someone still does this... welp. Ban He.

Images of changes

image
image

Testing

Loaded it offline, gave myself changeling, updated my flavor text, made a human, updated their flavor text. Transformed back and forth.
Cloned and noticed my DNA was okay with my flavor text.
Updated my flavor text through the IC tab and had no issues.
Made myself an abductor agent. And a nukie. No issues.

Changelog

🆑
fix: Fixed flavor text and changeling interactions.
/:cl:

@Spaghetti-bit Spaghetti-bit added Fix This PR will fix an issue in the game Refactor This PR will clean up the code but have the same ingame outcome Oversight This was forgotten about labels Jun 30, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jun 30, 2024
@Spaghetti-bit Spaghetti-bit requested a review from FaronCD July 1, 2024 02:40
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, would like another person to look at this before putting it in.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jul 1, 2024
@Spaghetti-bit Spaghetti-bit changed the title [FIX/Refactor] Changelings now update their flavor text upon transforming. Updates DNA to include flavor text. Changelings now update their flavor text upon transforming. Updates DNA to include flavor text. Jul 2, 2024
@Burzah Burzah added this pull request to the merge queue Jul 3, 2024
Merged via the queue into ParadiseSS13:master with commit 3e46e52 Jul 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game Oversight This was forgotten about Refactor This PR will clean up the code but have the same ingame outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulpkanins sometimes keep their tall as a changeling, and flavor text inconsistency
6 participants