Skip to content

Slimepeople feature #25446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Slimepeople feature #25446

wants to merge 3 commits into from

Conversation

robustinII
Copy link

@robustinII robustinII commented May 11, 2024 •
edited
Loading

What Does This PR Do

Now slimepeople can change their hair and beard styles without mirror. Just it needs a bit more time.

actually just a port from old rupara. I just made fresh TGUI Input instead of regular and boring input menu

Why It's Good For The Game

idk rp maybe

Images of changes

bandicam.2024-05-11.20-30-52-768.mp4

Testing

everything above

Changelog

🆑
add: two new slimepeople's innate actions - change hair and change beard
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label May 11, 2024
@Daylight2
Copy link
Contributor

Could the new abilities and even the old ones also have different icons? There's no way to visually diffenerentiate any of these, and if you have to mouse over them to see what they're named, they might as well be in their own tab instead of on the UI.

Scribble-Sheep
Scribble-Sheep suggested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Scribble-Sheep Scribble-Sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я Found a stowaway!

code/modules/mob/living/carbon/human/species/slimepeople.dm Outdated
if(do_after(H, SLIMEPERSON_HAIRGROWTHDELAY, target = H))
H.change_hair(new_style)
H.adjust_nutrition(-SLIMEPERSON_HAIRGROWTHCOST)
H.visible_message("<span class='notice'>[H] changes hairstyle.</span>", "<span class='notice'>You changed your hairstyleя.</span>")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
H.visible_message("<span class='notice'>[H] changes hairstyle.</span>", "<span class='notice'>You changed your hairstyleя.</span>")
H.visible_message("<span class='notice'>[H] changes hairstyle.</span>", "<span class='notice'>You changed your hairstyle.</span>")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shit. thx.

@SteelSlayer SteelSlayer added the Feature This PR is a new addition to the game label May 16, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels May 16, 2024
@robustinII
Copy link
Author

amogus
image

@Daylight2
Copy link
Contributor

amogus image

That's good. If you want it to be reeeealy cool, you could also try automatically recoloring the sprites to match the color of your body, but that's above and beyond of what's actually needed.

@robustinII
Copy link
Author

amogus image

That's good. If you want it to be reeeealy cool, you could also try automatically recoloring the sprites to match the color of your body, but that's above and beyond of what's actually needed.

idk how to do this...

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team Sprites This PR modifies the game sprites and removed -Status: Awaiting approval This PR is waiting for approval internally labels May 19, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions bot added the Stale This PR has been left inactive and requires an update. label Jun 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has not received any updates since being marked stale, and as such is now being automatically closed. Please feel free to re-open this pull request or open a new one once you have new updates.

@github-actions github-actions bot closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scribble-Sheep Scribble-Sheep Scribble-Sheep requested changes

Assignees
No one assigned
Labels
-Status: Awaiting review This PR is awaiting review from the review team Feature This PR is a new addition to the game Merge Conflict This PR is merge conflicted Sprites This PR modifies the game sprites Stale This PR has been left inactive and requires an update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@robustinII @Daylight2 @Scribble-Sheep @ParadiseSS13-Bot @SteelSlayer @AreYouGoingToSanFransico