[GBP NO UPDATE][READY FOR TM] Simplemob GC improvement #19225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
AffectedArc07
added
Fix
ParadiseSS13-Bot
added
Testmerge Requested
|
Local testing went well, gonna see if I can get this TMed onto the testserver for further testing |
GDNgit
changed the title
GDNgit
changed the title
SteelSlayer
approved these changes
Oct 19, 2022
ParadiseSS13-Bot
added
-Status: Awaiting merge
hal9000PR
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Basically, a continuation of what #19171 is doing, extended to (now) all simplemobs. Sadly, many of these animals still fail to GC for other reasons (such as status effects and hud issues)
This fixes false positives due to walk_to not getting reset on a significant amount of mobs
GBP NO UPDATE due to warriorstar doing the majority of the actual work to find and solve these issues, not me!
Why It's Good For The Game
GCing good, failing to GC bad
Failing to GC at a mass scale is incredibly bad
Testing
Local testing went well
Testing on the testserver went well, didn't notice any behavior differences.
Compiled, ran, screwed around with space carp and other simplemobs, more GCing than before on being deleted/killed.
Changelog
🆑
fix: Simplemobs GC more consistantly
/:cl: