Skip to content

GC fix bundle #1 #16609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 7, 2021
Merged

GC fix bundle #1 #16609

merged 13 commits into from
Sep 7, 2021

Conversation

SabreML
Copy link
Contributor

@SabreML SabreML commented Aug 28, 2021

What Does This PR Do

Fixes a bunch of GC issues that I found using #16607, as well as making some of them Initialize() where possible.
Each fix is in its own commit to make it easier to review.

Fixes:

(Not in order for some reason)
AI camera
AI headset
AI PDA
AI photos
AI
Ambulance
Analyzer
Clone pod
Fax
Imprinter
Material container
Nanomob
Protolathe
radio
RD Console
0Qd8HtUOTY

Why It's Good For The Game

Fixes!

Changelog

N/A

@AffectedArc07 AffectedArc07 added GC Related This PR optimises how a type GCs Refactor This PR will clean up the code but have the same ingame outcome labels Aug 28, 2021
@@ -12,6 +12,11 @@
AA = new(src)
soundloop = new(list(src), FALSE)

/obj/vehicle/ambulance/Destroy()
QDEL_NULL(AA)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How dare you

@SabreML
Copy link
Contributor Author

SabreML commented Aug 29, 2021

My computer's decided that it's going to BSOD any time I try doing something HDD-intensive. (See: Opening VSCode, Compiling the game code, Sometimes even just starting up my PC)
Because of this it may take a bit longer than hoped to address the reviews, so sorry about that.

Copy link
Contributor

@dearmochi dearmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit and Farie's reviews aside, LGTM

Copy link
Member

@hal9000PR hal9000PR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you are at it

/mob/living/simple_animal/hostile/scarybat/New(loc, mob/living/L as mob)
    ..()
    if(istype(L))
        owner = L

this never nulls the owner if you could add this to your PR it would be helpful.

The bat faction needs to use \ref, since the faction check system uses that too.
@variableundefined variableundefined merged commit 841ad0f into ParadiseSS13:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Related This PR optimises how a type GCs Refactor This PR will clean up the code but have the same ingame outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants