-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
GC fix bundle #1 #16609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GC fix bundle #1 #16609
Conversation
@@ -12,6 +12,11 @@ | |||
AA = new(src) | |||
soundloop = new(list(src), FALSE) | |||
|
|||
/obj/vehicle/ambulance/Destroy() | |||
QDEL_NULL(AA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How dare you
My computer's decided that it's going to BSOD any time I try doing something HDD-intensive. (See: Opening VSCode, Compiling the game code, Sometimes even just starting up my PC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit and Farie's reviews aside, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while you are at it
/mob/living/simple_animal/hostile/scarybat/New(loc, mob/living/L as mob)
..()
if(istype(L))
owner = L
this never nulls the owner
if you could add this to your PR it would be helpful.
The bat faction needs to use \ref, since the faction check system uses that too.
What Does This PR Do
Fixes a bunch of GC issues that I found using #16607, as well as making some of them
Initialize()
where possible.Each fix is in its own commit to make it easier to review.
Fixes:
(Not in order for some reason)
















Why It's Good For The Game
Fixes!
Changelog
N/A