Skip to content

Game Preferences Update #13936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AffectedArc07
Copy link
Member

@AffectedArc07 AffectedArc07 commented Jul 27, 2020

What Does This PR Do

This PR updates the DB schema for a toggles_2 column since we are out of bitflags. It also condenses some single-bool columns into this bitflag (SQL update file will make sure existing prefs are preserved).

It also goes over the existing toggles to make it obvious what they are
Fixes #13733

And yes. This has been tested. thoroughly.

Why It's Good For The Game

We shouldnt be cut off from making more preference toggles

Changelog

🆑 AffectedArc07
add: Adds ability for us to store more preference toggles in the future
/:cl:

Copy link
Contributor

@farie82 farie82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks fine.
Yet I'm not 100% on making another bitflag variable on the client.
Can't we just parse the values when we load and save to the DB?

Using it this way is rather abstract compared to a boolean value

@AffectedArc07
Copy link
Member Author

The reason we need an entire new variable is a BYOND limitation, not a DB limitation. We can have many more flags in the DB by increasing the int size, but the actual limit is the byond numerical limit.

@Kyep
Copy link
Contributor

Kyep commented Jul 28, 2020

Note to self: add something to backend tooling which, during testmerge start, does a hard file check for the existence of SQL/updates/X-Y.sql. If not found, auto-cancel testmerge. This safety check should forcibly prevent TMing any PR which hasn't been updated since the last SQL update PR was merged.

@Fox-McCloud Fox-McCloud added SQL Change This PR modifies the game database. This PR must go through the host. Refactor This PR will clean up the code but have the same ingame outcome labels Jul 31, 2020
@github-actions github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Aug 16, 2020
@github-actions github-actions bot added Merge Conflict This PR is merge conflicted and removed Merge Conflict This PR is merge conflicted labels Sep 7, 2020
@AffectedArc07 AffectedArc07 removed the Merge Conflict This PR is merge conflicted label Sep 12, 2020
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Oct 4, 2020
@AffectedArc07 AffectedArc07 removed the Merge Conflict This PR is merge conflicted label Oct 5, 2020
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Oct 6, 2020
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Oct 8, 2020
@variableundefined variableundefined merged commit a50f656 into ParadiseSS13:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor This PR will clean up the code but have the same ingame outcome SQL Change This PR modifies the game database. This PR must go through the host.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We are out of bitflags
5 participants