-
-
Notifications
You must be signed in to change notification settings - Fork 447
Add icons for TheXTech and SMBX #4033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For consistency with existing icons, like this one that is already in the repository. Also, there doesn't seem to be anything in the design notes explicitly stating that
Are you comparing the svg from my original post preview or the files in the commit? I checked the files and all nodes making the shape of the element are aligned to the pixel grid, although I now noticed that the mushroom's stem is a few subpixels wider, would that be the issue? if so I can fix it shortly. |
https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/tools/work/DESIGN.md
It's SVG from inkscape 48px. Take a closer look, not only the mushroom stem has problems with pixel alignment, but also the eyes, the circles on the mushroom cap. |
|
|
As for shadows, we usually use 20%, but if the element is darker than the background, then the shadow will be 10%. In the corrected icon, I did it. please note that the mushroom cap is darker than the leg, so its shadow is 10% |
Should be good now. |
ok, i fix some elements |
TheXTech (left) and SMBX (right)