add zen browser icon

[sotha1]

No description provided.

[sotha1]

just realized the icons are stretched cuz i was working on a very high monitor...

[achadwick]

Quick review from me (I'm not a committer):

• There are matrix() transforms on the objects.
  • To get rid of them, please group everything once Ctrl+A Ctrl+G, then ungroup everything Ctrl+Shift+G until it's a flat structure. The Layers and Objects sidebar is incredibly useful to have open for this job.
• I like the choices you've made about where to align the concentric rings
• Often I suggest pure white for foreground designs over a base, but in this case the cream colour is just right for the orange (and also part of the branding)

A couple of design questions too, feel free to ignore them:

• Does it really need the shadows inside the outer circle edge?
  • It might be clearer without them
  • Reasonable to have the cream- and orange-coloured circles at the same level for this icon
  • Some icons do this, and look great. Kind of a "melted bead decoration" approach rather than a "layered paper" look.
• Does it really need the cream-coloured plinth?
  • I'm way less confident about dropping it, but the circles could be bigger at least
  • Would need to check on both light and dark backgrounds, because it might look bad on dark ones
  • Papirus doesn't like icons with holes in, so we can't use the natural background in place of the cream inner circles

Something without inner shadows or the plinth, just for discussion:

[sotha1]

Does it really need the shadows inside the outer circle edge?

yes! you're absolutely right. after that you said i just realized that the shadows make it look it's not perfectly round, like it's streched. i also will do that svg example you sent, it looks better to me too without the plinth. thanks for the tips!

[achadwick]

Looking at the history, there's a freecad update on this branch too, but it's a duplicate of the one in #3928 that's been merged already, so it'll merge cleanly on the principle of the same changes being present.

We're chasing February 1st for a release, and it would be good to have this attractive new web browser icon in Papirus before then.

I think the plinth design could be accepted as-is if we don't mind the matrix transforms, and time is pressing. It's 5 minutes work to get rid of them too. If slightly clearer redesign is ready on this branch though, that'd be great! I know it's a lot of fiddly circle realignment, though ;)

[sotha1]

no problem, I was already planning to work on them today

[sotha1]

@achadwick i didn't understand exactly what you mean, but i did what you said, is this right now?:

[achadwick]

@achadwick i didn't understand exactly what you mean, but i did what you said, is this right now?:

Yeah, that doesn't contain any matrix transforms now 🎉
You can check by looking at the SVG in a text editor and searching for "matrix". They often get stuck on groups and other elements when you transform the shapes (combinations of rotate, skew, scale), and grouping the elements and then fully ungrouping them in Inkscape fixes it ready for the commit. I should document it, I guess.

Please run "prepare.sh" to clean up the icons before "put-into-theme.sh" and committing+pushing with git. It's all documented here: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/tools/work/README.md#4-final-steps

I've just noticed that we're still recommending the wrong dependencies for scour (a tool that prepare.sh uses). It's "apt install scour" on modern Debian systems, not what the docs say. Weh. I'll update that document and the prepare script in a different PR.

[sotha1]

I've just noticed that we're still recommending the wrong dependencies for scour (a tool that prepare.sh uses). It's "apt install scour" on modern Debian systems, not what the docs say. Weh. I'll update that document and the prepare script in a different PR.

yes! i personally am using linux mint so i downloaded the scour package directly from the app store, i don't know if other distros also have that, but i think it would be cool if you advice that too, once it's more "user friendly"

[achadwick]

yes! i personally am using linux mint so i downloaded the scour package directly from the app store, i don't know if other distros also have that, but i think it would be cool if you advice that too, once it's more "user friendly"

No trouble. Most things have some sort of software center now. I'll advise https://repology.org/project/scour/versions too so folks can find an exact package name (I guess Mint get theirs from Ubuntu?)

[sotha1]

(I guess Mint get theirs from Ubuntu?)

yes

[achadwick]

Looks great now! Everything's neat and on the grid without any hidden transforms. If you're happy with the design, let's merge it.

@morganist: ready for merge here. Good alignments, tests all pass.

[morganist]

all right, the alignment is great, but it doesn't feel like a Papirus icon without the layering (no shadows). I guess it's easier that way because the icon only consists of circles, but subtle shadows under every orange ring would definitely give it the Papirus look. I'll merge and rework it from there, thanks!

[morganist]

i just realized that the shadows make it look it's not perfectly round, like it's streched. i also will do that svg example you sent, it looks better to me too without the plinth. thanks for the tips!

@sotha1 this may make the icons look stretched, but when rendered at the size they are supposed to, the shadows only really make the elements look layered and don't distort the shape. Layering is the distinguishing feature of Papirus, the same goes for pixel-perfect alignment, warm, juicy colours, and the base white colour. The icons as they are right now look like pixel-perfect rework of the original, and not like a Papirus icon (base white is too bright, no layering). Just give me a bit of time, I'll commit the fixes and tell me what you think.

[morganist]

How does that look?

[sotha1]

How does that look?

looks great for me! i haven't tested it on-the-go yet so i haven't seen how it would fit in, but at least now for me is great.