Update for the new Notesnook icon #3915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i propose some improvements: |
|
@morganist I missed that. Will fix ASAP. |
|
@morganist changes implemented EDIT: Never mind. i forgot to make test and it's showing errors D:. Will continue fixing this tomorrow |
|
@morganist OK now it's ready. Fully checked |
|
I've done some fixes here as well, e. g. shadows and some minor alignment work. By the way, try not to make 16px, 22px, and 24px monochrome (panel) icons all the same! It kind of defeats the purpose of multiple sizes, we try to do a normal variant for 22px and 24px, and a smaller one for 16 px. Here I've just increased the padding a bit to make the icon bigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon of Notesnook was changed a while back. This is an update for it.
closes #3754