Skip to content

Add and fix some symlinks for YaST #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Add and fix some symlinks for YaST #3526

merged 3 commits into from
Aug 20, 2023

Conversation

morganist
Copy link
Member

Fixed the symlink for system update - its name was yast-system_update, when the actual name needs to be yast-system-update (with a dash, not an underscore);
Symlink several more system update/upgrade things to system-software-update;
Symlinked the firewall icon to an actual firewall icon (firewall-config);
The AppArmor icon is now symlinked to gufw;
Symlinked yast-journal to utilities-log-viewer;
Added icons for yast-vpn (copied VPN device icons);
yast-auth-client is now symlinked to users icon.

@SmartFinn
Copy link
Member

@morganist Btw, what distro are you using?

@morganist
Copy link
Member Author

@morganist Btw, what distro are you using?

i use opensuse tumbleweed. kind of a bummer that papirus icons is kind of a low priority package and latest releases don't get built soon enough. the previous one was actually 2 months old when it hit the main repos, but I've found a community git package yesterday.

@SmartFinn
Copy link
Member

@morganist Great! I sometimes download livecd of the various distros to check our icons in them, and now I know I don't have to worry about OpenSUSE.

@morganist
Copy link
Member Author

@morganist Great! I sometimes download livecd of the various distros to check our icons in them, and now I know I don't have to worry about OpenSUSE.

Papirus works great! Doesn't matter if it is installed with a package manager or with KDE's "get new stuff" button (KDE Store).
I specifically have gone through YaST icons in Papirus today and matched them with a desktop files for various YaST programs (they act as a different tools but are accessible from a single interface as well as a standalone applications with their own .desktop files) and found many icons just fallbacking to 'yast' icon because of incorrect symlinks or a lack of it. This should fix all the easy stuff but some icons require a bit of thinking to get right (for example an icon for a kernel settings, because I haven't found one).

@SmartFinn SmartFinn merged commit f5471f7 into PapirusDevelopmentTeam:master Aug 20, 2023
@morganist morganist deleted the yast-online-update branch August 20, 2023 12:02
@SmartFinn
Copy link
Member

@morganist seems yast-update-online is correct icon name, not yast-online-update. Could you check it on your system?

image

@morganist
Copy link
Member Author

@SmartFinn oops, you are correct, it is the same on my system.

[Desktop Entry]
X-SuSE-DocTeamID=ycc_org.opensuse.yast.OnlineUpdate
Type=Application
Categories=Settings;System;Qt;X-SuSE-YaST;X-SuSE-YaST-Software;

X-KDE-ModuleType=Library
X-KDE-HasReadOnlyMode=true
X-SuSE-YaST-Call=online_update

X-SuSE-YaST-Group=Software
X-SuSE-YaST-Argument=
X-SuSE-YaST-RootOnly=true
X-SuSE-YaST-Geometry=
X-SuSE-YaST-SortKey=10
X-SuSE-YaST-AutoInstResource=
X-SuSE-YaST-AutoInst=
X-SuSE-YaST-Keywords=software,update,online,YOU,packages,RPM

Icon=yast-update-online
Exec=xdg-su -c "/sbin/yast2 online_update"

Name=YaST Online Update
GenericName=Online Update
Comment=Get patches to correct and improve your existing installation
StartupNotify=true

I was apparently confused with that underscore and mixed the names up the same way. Could you fix it? Or I can reopen this branch and this issue. Maybe it would also be better to delete the symlink to yast-update-online-configuration so it falls back to yast-update-online? At least before it gets its own icon, maybe.

@morganist
Copy link
Member Author

Also, sorry for a silly mistake.... Digging through YaST icons and desktop files is rather confusing...

@SmartFinn
Copy link
Member

@morganist

Maybe it would also be better to delete the symlink to yast-update-online-configuration so it falls back to yast-update-online? At least before it gets its own icon, maybe.

OK, I'm going to do these fixes.

SmartFinn added a commit that referenced this pull request Aug 20, 2023
Delete yast-update-online-configuration.svg symlink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants