Feat: Improve attack cooldown API #12806
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small pull that exposes the
attackStrengthTickerof nms.LivingEntity through obb.Player.There isn't currently any point in exposing this through obb.LivingEntity as it isn't currently used anywhere except in nms.Player.
If that changes in the future, moving it to obb.LivingEntity wouldn't break the bytecode of plugins, as obb.Player extends obb.LivingEntity anyway.
This plugs a gap in the API where it currently provides no way of setting the current attack cooldown (without a lot of hackery, at least)
Not sure exactly what to call the methods in their current context. Keeping them similar to their related methods unless anyone can think of better names.
Representing the value as a long rather than an int in the event the underlying field changes to a long.