Skip to content

NoMongo (dependencies): remove unused devDependencies and update packages #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Bittukr7479
Copy link

@Bittukr7479 Bittukr7479 commented Apr 13, 2025

What kind of change does this PR introduce?

Issue Number:

Fixes #3435

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Checklist

CodeRabbit AI Review

  • I have reviewed and addressed all critical issues flagged by CodeRabbit AI
  • I have implemented or provided justification for each non-critical suggestion
  • I have documented my reasoning in the PR comments where CodeRabbit AI suggestions were not implemented

Test Coverage

  • I have written tests for all new changes/features
  • I have verified that test coverage meets or exceeds 95%
  • I have run the test suite locally and all tests pass

Other information

Have you read the contributing guide?

Summary by CodeRabbit

  • Chores
    • Streamlined developer dependencies by removing unused packages.
    • Updated testing-related packages to their latest versions for improved performance.

Copy link

coderabbitai bot commented Apr 13, 2025

Walkthrough

This pull request modifies the package.json file by removing two development dependencies (@docusaurus/tsconfig and typedoc-plugin-markdown) and updating the versions of @vitest/coverage-v8 and vitest from ^3.0.3 to ^3.1.1. These changes simplify the dependency list and ensure updated versions of testing tools are used.

Changes

File(s) Change Summary
package.json Removed devDependencies: @docusaurus/tsconfig, typedoc-plugin-markdown; Updated dependency versions: @vitest/coverage-v8 and vitest from ^3.0.3 to ^3.1.1

Assessment against linked issues

Objective Addressed Explanation
Remove unused dependencies (#3435)
Add any missing dependencies (#3435) No additional dependencies have been added.
Create testing automation (GitHub action and husky pre-commit check) (#3435) Automation for unused dependency checks is not included.

Possibly related PRs

Suggested labels

ignore-sensitive-files-pr

Suggested reviewers

  • disha1202
  • GlenDsza
  • palisadoes

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c40fbf and 202d8cf.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
🔇 Additional comments (2)
package.json (2)

47-47: Updated @vitest/coverage-v8 Dependency Version

The dependency has been updated from an older version (likely ^3.0.3) to ^3.1.1 as intended by the PR objectives. Please verify that the updated version is fully compatible with your test setup and that there are no breaking changes in its API.


58-58: Updated vitest Dependency Version

The version of vitest has been updated to ^3.1.1, which aligns with the update made for @vitest/coverage-v8. This should help maintain consistency in your testing tools. Ensure that you run the test suite to confirm all tests pass with the new version.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@palisadoes
Copy link
Contributor

Please validate that the devcontainer starts with these changes

Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.07%. Comparing base (8c40fbf) to head (202d8cf).
Report is 1 commits behind head on develop-postgres.

Additional details and impacted files
@@                Coverage Diff                @@
##           develop-postgres    #3453   +/-   ##
=================================================
  Coverage             59.07%   59.07%           
=================================================
  Files                   523      523           
  Lines                 40674    40674           
  Branches               1735     1735           
=================================================
  Hits                  24030    24030           
  Misses                16635    16635           
  Partials                  9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bittukr7479
Copy link
Author

Please validate that the devcontainer starts with these changes

Ok sir, I am checking.

@palisadoes palisadoes added the ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files label Apr 13, 2025
@palisadoes
Copy link
Contributor

Does it start?

@Bittukr7479
Copy link
Author

Does it start?

I'm currently stuck due to some issues with my setup. I will need a bit more time to validate this PR.

@Bittukr7479
Copy link
Author

image
image

Sir, It's validated by starting with devcontainer.

@Bittukr7479
Copy link
Author

@palisadoes sir my devcontainer is running but still facing issue in https://test.talawa.io/ image

@palisadoes palisadoes merged commit 266adb1 into PalisadoesFoundation:develop-postgres Apr 13, 2025
17 of 18 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in NoMongo: Talawa-API Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants