Added corrections #2895
Added corrections #2895
Conversation
Signed-off-by: NishantSinghhhhh <[email protected]>
WalkthroughThis pull request introduces modifications to the Docusaurus documentation configuration and styling. The changes include updating the navigation configuration in Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #2895 +/- ##
===================================================
Coverage ? 39.85%
===================================================
Files ? 453
Lines ? 33203
Branches ? 385
===================================================
Hits ? 13234
Misses ? 19969
Partials ? 0 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
docs/docusaurus.config.ts(1 hunks)docs/src/components/layout/HeaderHero.tsx(1 hunks)docs/src/css/custom.css(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Run tests for talawa api
- GitHub Check: Analyse Code With CodeQL (typescript)
🔇 Additional comments (2)
docs/docusaurus.config.ts (1)
70-71: Verify that external linking is intentional.
Including both"type": "docSidebar"and"href"in the same item is somewhat unconventional and may override the docSidebar functionality. If linking to an external site is indeed intended, consider removing thetypeandsidebarIdproperties.docs/src/css/custom.css (1)
1268-1278: Great approach to fix image cut-off issues.
Usingoverflow: hiddenandobject-fit: containensures the entire image is visible without distortion. This looks good!
|
@palisadoes , I have added the changes you have pointed out in [https://github.com//pull/2878#issuecomment-2605398322] |
|
Please merge with the latest upstream. There have been significant changes |
Signed-off-by: NishantSinghhhhh <[email protected]>
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
|
@palisadoes, I have already pulled all the code from |
varshith257
added
the
ignore-sensitive-files-pr
| src={useBaseUrl("img/image-01.png")} | ||
| alt="Talawa member management software interface showcase" | ||
| loading="lazy" | ||
| // srcSet={`${useBaseUrl("img/image-01.png")} 1x, ${useBaseUrl("img/[email protected]")} 2x`} |
There was a problem hiding this comment.
What I saw on localhost , the image was not rendering when both src and srcset were present ,
After srcset was commented out , the image rendered , if you want me to uncomment, I can do so
|
I got mixed up with Admin. |
palisadoes
merged commit 6c201af
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Bugfix
Issue Number:
Fixes
Snapshots/Videos:
Summary
Understood. I will follow the Concise Mode instructions in responding to your request.
To address the image cut-off issue:
overflow: hiddento ensure the entire image is visible.autoto allow it to scale proportionally.object-fit: containto fit the image within the container.This should resolve the cut-off problem on wide screens. Let me know if you have any other questions!
Does this PR introduce a breaking change?
No
Summary by CodeRabbit
Documentation
Style
.image-containerCSS class to manage image display and sizingobject-fit: containChores
index.tsxfile for cleaner code structure