Skip to content

Upgrade package graphql from 16.8.1 to 16.9.0 #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
palisadoes opened this issue Jul 5, 2024 · 1 comment
Closed

Upgrade package graphql from 16.8.1 to 16.9.0 #2382

palisadoes opened this issue Jul 5, 2024 · 1 comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers no-issue-activity No issue activity security Security fix unapproved Unapproved for Pull Request

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade graphql from 16.8.1 to 16.9.0.
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

Release Note Details

Bumps graphql from 16.8.1 to 16.9.0.

Release notes

Sourced from graphql's releases.

v16.9.0 (2024-06-21)

New Feature 🚀

  • #4119 backport[v16]: Introduce "recommended" validation rules (@​benjie)
  • #4122 backport[v16]: Enable passing values configuration to GraphQLEnumType as a thunk (@​benjie)
  • #4124 backport[v16]: Implement OneOf Input Objects via @oneOf directive (@​benjie)

Committers: 1

v16.8.2 (2024-06-12)

Bug Fix 🐞

Internal 🏠

Committers: 2

Commits
  • 556a01e 16.9.0
  • 6a1614c backport[v16]: Enable passing values configuration to GraphQLEnumType as a th...
  • 29144f7 backport[v16]: Implement OneOf Input Objects via @oneOf directive (#4124)
  • c35130e Revert error extension symbol (#4123)
  • 29c1bff feat: allow defining symbol error extensions (#3730)
  • c985c27 backport[v16]: Introduce "recommended" validation rules (#4119)
  • 08779a0 16.8.2
  • c82609e Fix publish scripts (#4104)
  • 0d12b06 fix: remove globalThis check and align with what bundlers can accept (#4022)
  • See full diff in compare view
Maintainer changes

This version was pushed to npm by benjie, a new releaser for graphql since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@palisadoes palisadoes added bug Something isn't working good first issue Good for newcomers unapproved Unapproved for Pull Request security Security fix dependencies Pull requests that update a dependency file labels Jul 5, 2024
@github-actions GitHub Actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jul 16, 2024
Aaradhy-Sharma added a commit to Aaradhy-Sharma/talawa-api that referenced this issue Jul 24, 2024
@Aaradhy-Sharma
fix: issue PalisadoesFoundation#2382 by upgrading graphql version
d164ddd 
- Updated the `graphql` dependency in `package.json` from version `^16.8.1` to `^16.9.0`
- Regenerated `package-lock.json` to reflect the changes in dependencies

This change addresses issue PalisadoesFoundation#2382 by ensuring compatibility with the latest features and bug fixes in the `graphql` package.

Closes PalisadoesFoundation#2382
@Aaradhy-Sharma Aaradhy-Sharma mentioned this issue Jul 24, 2024
Merged
palisadoes pushed a commit that referenced this issue Jul 25, 2024
@Aaradhy-Sharma
fix: issue #2382 by upgrading graphql version (#2415)
7258cfd 
- Updated the `graphql` dependency in `package.json` from version `^16.8.1` to `^16.9.0`
- Regenerated `package-lock.json` to reflect the changes in dependencies

This change addresses issue #2382 by ensuring compatibility with the latest features and bug fixes in the `graphql` package.

Closes #2382
palisadoes pushed a commit that referenced this issue Jul 27, 2024
@Aaradhy-Sharma
Add tests for 100% coverage of src/resolvers/User/posts.ts (#2417)
1f38da5 
* fix: issue #2382 by upgrading graphql version

- Updated the `graphql` dependency in `package.json` from version `^16.8.1` to `^16.9.0`
- Regenerated `package-lock.json` to reflect the changes in dependencies

This change addresses issue #2382 by ensuring compatibility with the latest features and bug fixes in the `graphql` package.

Closes #2382

* test: Add tests for 100% coverage of src/resolvers/User/posts.ts

- Implemented comprehensive test cases for `posts.ts` to ensure 100% code coverage.
- Added tests for various pagination arguments (`first`, `last`, `before`, `after`).
- Included edge cases for no posts and invalid filters.
- Verified error handling for invalid arguments and cursor values.

Fixes #1928

* test: Add tests for 100% coverage of src/resolvers/User/posts.ts update-2

* Fix and improve User post resolver tests

- Update 'handles valid cursor value' test to be more flexible
- Ensure test passes with variable post order
- Maintain test coverage and functionality verification
@coderabbitai coderabbitai bot mentioned this issue Aug 16, 2024
Merged
This was referenced Aug 23, 2024
Closed
Closed
Closed
Closed
@coderabbitai coderabbitai bot mentioned this issue Sep 2, 2024
Closed
@coderabbitai coderabbitai bot mentioned this issue Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file good first issue Good for newcomers no-issue-activity No issue activity security Security fix unapproved Unapproved for Pull Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@palisadoes