Skip to content

No Mongo: Separate URIs for User Login, Admin Login and Registration #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palisadoes opened this issue Feb 23, 2025 · 12 comments
Open
Labels
documentation Improvements or additions to documentation feature request MVP Needed for our 2025 MVP

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Feb 23, 2025

Is your feature request related to a problem? Please describe.

The current login and registration screens are confusing we need them to be simplified.

Describe the solution you'd like

  1. Screens:

    1. Regular users should login to the / URI
    2. Admins should login to the /admin URI
      1. It should have a shadow effect on a white background like the lost password screen.
    3. Registration should login to the /register URI
      1. It should have a shadow effect on a white background like the lost password screen.
        1. https://www.figma.com/design/dmKt00m9GVSeA1nebnkxql/Untitled?node-id=0-1&p=f&t=ylMk7PQbhgMtbV8R-0
      2. It must be subtly distinctive from the Admin login screen 1. Must only use CSS references from this stylesheet, using existing entries whenever possible.
      3. src/style/app-fixed.module.css
  2. Appropriate Markdown documentation needs to be added7. All tests must be comprehensive attaining 100% code coverage, and must be valid.Describe alternatives you've considered- N/A
    Additional context

  3. User Login
    Image

  4. Admin Login
    Image

  5. Register
    Image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added documentation Improvements or additions to documentation unapproved labels Feb 23, 2025
@anya-xcode
Copy link

anya-xcode commented Feb 23, 2025

@palisadoes Please assign this to me; I would like to work on this issue.

@anya-xcode
Copy link

Hi, my question regarding the login page flow. Currently, when users open the website, they land on the login page. However, in the screenshots provided, there doesn't seem to be any visible button for the "User Login" or "Register" options. This raises a question about how users are supposed to navigate to the registration page or the admin login page.

Additionally, regarding the "Forgot Password" screen, could you please clarify what kind of shadow effect you're looking for?

@palisadoes
Copy link
Contributor Author

  1. Add a subtle link for registration on both login pages
  2. The admin login URI will be documented on the talawa website. There shouldn't be a link to it from the regular login page. This will help reduce non admins, who will greatly outnumber admins, from clicking on the admin login page in error
  3. Please re-read the URIs and their function.

@palisadoes
Copy link
Contributor Author

I added a link to our figma design

@anya-xcode
Copy link

@palisadoes Okay, I got it! I will raise a PR as soon as possible.

@anya-xcode
Copy link

@palisadoes Please review!

@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity

@adithyanotfound
Copy link
Contributor

Please assign

palisadoes pushed a commit that referenced this issue Apr 7, 2025
#3736) (#3915)

* Added separate URLs

* Coderabbit ai suggestions

* Added index.html to sensitive files

* Remove login and register btns

* lint

* Update register logic

* Fix tests

* Update documentation
AryanSwaroop pushed a commit to AryanSwaroop/talawa-admin that referenced this issue Apr 13, 2025
PalisadoesFoundation#3736) (PalisadoesFoundation#3915)

* Added separate URLs

* Coderabbit ai suggestions

* Added index.html to sensitive files

* Remove login and register btns

* lint

* Update register logic

* Fix tests

* Update documentation
@palisadoes
Copy link
Contributor Author

@adithyanotfound

This needs to be reopened and fixed properly.

https://palisadoes-foundation.slack.com/archives/C01RPC00K0D/p1744995228110849

@palisadoes palisadoes reopened this Apr 18, 2025
@bandhan-majumder
Copy link
Contributor

@palisadoes , I have commented on the discussion that the issue was purposed to only separate the screen. If the admin logs in as regular user, they should see the regular user screen. If they want to see the admin screen, they should login with admin login screen. Is it not the intended behavior? Or I am missing something?

@palisadoes
Copy link
Contributor Author

@palisadoes , I have commented on the discussion that the issue was purposed to only separate the screen. If the admin logs in as regular user, they should see the regular user screen. If they want to see the admin screen, they should login with admin login screen. Is it not the intended behavior? Or I am missing something?

Yes

@palisadoes
Copy link
Contributor Author

Unassigned. Inactivity

@palisadoes palisadoes added MVP Needed for our 2025 MVP and removed GSoC Priority labels May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request MVP Needed for our 2025 MVP
Projects
None yet
4 participants