-
-
Notifications
You must be signed in to change notification settings - Fork 888
NoMongo: Replace Base64 Storage with MinIO Client in CreateGroupChat.tsx #3724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@palisadoes Can i be assinged? |
PTAL at the XSS and CORS vulnerabilities mentioned above that you will need to address as part of this. |
Unassigning. 2 weeks of inactivity |
Please assign |
Is anyone currently working on this, or should I create a new issue for setting up a centralized MinIO configuration? |
Thanks but All configurations are almost implemented am doing it all. |
Uh oh!
There was an error while loading. Please reload this page.
Problem
CreateGroupChat.tsx currently stores images and media using Base64 encoding, increasing memory usage and slowing down performance.
Solution
Integrate MinIO client for direct file uploads, storing only file URLs instead of Base64 strings.
Alternatives Considered
Approach
Additional Context
This change will improve performance, reduce payload size, and optimize storage.
NOTE
We recently discovered a flaw in the code base where there are some XSS and CORS vulnerabilities. This occurs when the API and Admin servers run on different machines.
You will notice this if you configure your Admin app on your local machine to use the API running on https://test.talawa.io/graphql.
The errors in your browser will look like this:
As part of this issue you will need to ensure that the browser only interacts with the API through the Admin server and never with the API directly.
The text was updated successfully, but these errors were encountered: