-
-
Notifications
You must be signed in to change notification settings - Fork 895
NoMongo: Postgres Migration Support for Advertisement
in orgDashboard
#3557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@palisadoes @gautam-divyanshu can i work on this ? |
@gautam-divyanshu I want to work on this issue please assign me. |
Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too. |
Ok sir, don't worry. |
Can I work on this sir? |
Yes |
Please assign me I would like to work on it. |
This issue aims to restore functionality to the app after migrating to a PostgreSQL API back end.
|
@palisadoes If no one is working on this, I'd like to take it. |
@JaiPannu-IITI I am working actually had college exams so I was busy for past few days will Update the work soon since exams are over. |
Perfect, take your time !! |
@palisadoes @gautam-divyanshu while I was solving this issue to get all the advertisments to be shown in frontend .I Think we need to have a change in talawa-api in advertisments.ts here we have query to get only 1 advertisment at a time. we need to have a query with findMany to fetch all the advertisments. similarly in graphql.schema too we need to add a query here since this is issue is to work on talawa-admin codebase but since we need to update talawa-api too should I open an issue there? Please let me know if I am lacking something.Looking forward thanks |
Also the possible solution I see to show active and completed advertisements on this page is that first we fetch all the advertisements for a particular organisation from the backend and filter them as active or completed in frontend and show the data. |
Thanks.
|
Sure I will look into it. |
@palisadoes Sir,I have completed around 70% of the work and would really appreciate your feedback. advertismentWork.1.mp4Things that are still pending:
|
How's progress on this? It needs to be completed as a GSoC prerequisite. |
Everything is done I am just failing some test cases in 3 files in test files. |
…for Advertisement in orgDashboard
@udayempire are you still working on this? Can I help you fix? |
@bandhan-majumder i will be glad if u can currently the issue is with failing test cases ...rest functionality wise its working |
Sure @udayempire . It will be helpful for me if you make sure that there are no conflicts in the existing pr so that while failing in the test cases in the workflow check, I can utilized it for changes needed. |
Sure |
Hi sorry for being late you can check the pr as there arent any conflicting pr |
@udayempire the errors are causing because there are multiple imports of the same things in a single file and some things are not imported at all but used in the file. I have added comments in 2 such areas. The errors are pretty self explanatory. Did you push the code from CLI? Our pre-commit hook should already prevent this though. Let me know if you need more info about it. |
But I havent updated the code in organization file then why it is coming? |
|
Also can you check the 3 files i mentioned I removed all the test errors in entry.spec just 1-2 is there.. |
check slack dm. |
we have discussed and @bandhan-majumder can fix the next issues please assign him this issue |
Thanks @udayempire. @palisadoes @Cioppolo14 please assign. I will fix this ASAP. |
Should one be able to upload multiple attachments? Currently it's supporting a single one. If so, how the multiple attachments will be displayed? In a sliding manner from left to right? Also, updating media files are not supported til now. Should I add them in api? |
Yes to both questions |
@palisadoes Alright. |
update: basic functionalities are recovered https://www.loom.com/share/8f83dc4a7f6a4dfa8e7e879476f00844 working on optimization and tests for now. |
Is your feature request related to a problem? Please describe.
Update query and mutations according to the recently migrated
develop-postgres
branch oftalawa-api.
Describe the solution you'd like
Make the schema support the changes
Currently no advertisements in develop-postgres
Expected:
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: