Skip to content

NoMongo: Postgres Migration Support for Advertisement in orgDashboard #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gautam-divyanshu opened this issue Feb 7, 2025 · 44 comments
Closed
Assignees
Labels
feature request GSoC Priority refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@gautam-divyanshu
Copy link
Member

Is your feature request related to a problem? Please describe.
Update query and mutations according to the recently migrated develop-postgres branch of talawa-api.

Describe the solution you'd like
Make the schema support the changes

Currently no advertisements in develop-postgres

Image

Expected:

Image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@yashaghane21
Copy link

yashaghane21 commented Feb 8, 2025

@palisadoes @gautam-divyanshu can i work on this ?

@Bittukr7479
Copy link

@gautam-divyanshu I want to work on this issue please assign me.

@mpdesai90
Copy link

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@Bittukr7479
Copy link

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

Ok sir, don't worry.

@udayempire
Copy link

Can I work on this sir?

@udayempire
Copy link

Also Just to clarify I am not wrong we want to make sure that that we are able to make advertisments in the server using this -

Image

@palisadoes
Copy link
Contributor

Yes

@udayempire
Copy link

Yes

Please assign me I would like to work on it.

@palisadoes palisadoes added GSoC Priority ui/ux issue related and being worked with the figma file of the Admin UI labels Feb 10, 2025
@palisadoes
Copy link
Contributor

This issue aims to restore functionality to the app after migrating to a PostgreSQL API back end.

  1. This is a high priority issue. It's a prerequisite for our GSoC ideas.
  2. The develop branches of Talawa Admin and Talawa API work together. Use those branches to determine the expected behavior of the apps.
  3. Compare the operation of Talawa Admin and Talawa API running together in the develop-postgres branch.
  4. Submit your PR against the develop-postgres branch and attach a video.

@JaiPannu-IITI
Copy link

@palisadoes If no one is working on this, I'd like to take it.

@udayempire
Copy link

@JaiPannu-IITI I am working actually had college exams so I was busy for past few days will Update the work soon since exams are over.

@JaiPannu-IITI
Copy link

Perfect, take your time !!

@udayempire
Copy link

udayempire commented Feb 16, 2025

@palisadoes @gautam-divyanshu while I was solving this issue to get all the advertisments to be shown in frontend .I Think we need to have a change in talawa-api in advertisments.ts here we have query to get only 1 advertisment at a time.

we need to have a query with findMany to fetch all the advertisments.

Image

similarly in graphql.schema too we need to add a query here

Image

since this is issue is to work on talawa-admin codebase but since we need to update talawa-api too should I open an issue there?

Please let me know if I am lacking something.Looking forward thanks

@udayempire
Copy link

udayempire commented Feb 16, 2025

Also the possible solution I see to show active and completed advertisements on this page is that first we fetch all the advertisements for a particular organisation from the backend and filter them as active or completed in frontend and show the data.

@palisadoes
Copy link
Contributor

Thanks.

  1. Please open an issue to update the API
  2. It'll be best to filter by organization and date range by default with options for further filtering by the active/completed status

@udayempire
Copy link

Sure I will look into it.

@udayempire
Copy link

@palisadoes Sir,I have completed around 70% of the work and would really appreciate your feedback.

advertismentWork.1.mp4

Things that are still pending:

  1. Media Attachments: I haven't implemented the functionality to attach media images yet.
  2. Auto-Scrolling Ads: When the limit is set to 6 ads, new ads do not automatically scroll into view.
  3. Frontend Refresh Issue: Changes in advertisements do not reflect instantly on the frontend; a manual page refresh is required to see updates.

@palisadoes
Copy link
Contributor

How's progress on this? It needs to be completed as a GSoC prerequisite.

@udayempire
Copy link

udayempire commented Mar 9, 2025

Everything is done I am just failing some test cases in 3 files in test files.

udayempire added a commit to udayempire/talawa-admin that referenced this issue Mar 14, 2025
@bandhan-majumder
Copy link
Contributor

bandhan-majumder commented Mar 17, 2025

@udayempire are you still working on this? Can I help you fix?

@udayempire
Copy link

@bandhan-majumder i will be glad if u can currently the issue is with failing test cases ...rest functionality wise its working

@bandhan-majumder
Copy link
Contributor

Sure @udayempire . It will be helpful for me if you make sure that there are no conflicts in the existing pr so that while failing in the test cases in the workflow check, I can utilized it for changes needed.

@udayempire
Copy link

Sure @udayempire . It will be helpful for me if you make sure that there are no conflicts in the existing pr so that while failing in the test cases in the workflow check, I can utilized it for changes needed.

Sure

@udayempire
Copy link

Sure @udayempire . It will be helpful for me if you make sure that there are no conflicts in the existing pr so that while failing in the test cases in the workflow check, I can utilized it for changes needed.

Hi sorry for being late you can check the pr as there arent any conflicting pr

@bandhan-majumder
Copy link
Contributor

@udayempire the errors are causing because there are multiple imports of the same things in a single file and some things are not imported at all but used in the file. I have added comments in 2 such areas. The errors are pretty self explanatory. Did you push the code from CLI? Our pre-commit hook should already prevent this though. Let me know if you need more info about it.

Image

Image

@udayempire
Copy link

But I havent updated the code in organization file then why it is coming?

@udayempire
Copy link

udayempire commented Mar 19, 2025

But I havent updated the code in organization file then why it is coming?its just the pulled code.

@udayempire
Copy link

Also can you check the 3 files i mentioned I removed all the test errors in entry.spec just 1-2 is there..

@bandhan-majumder
Copy link
Contributor

check slack dm.

@udayempire
Copy link

we have discussed and @bandhan-majumder can fix the next issues please assign him this issue

@bandhan-majumder
Copy link
Contributor

bandhan-majumder commented Mar 28, 2025

Thanks @udayempire. @palisadoes @Cioppolo14 please assign. I will fix this ASAP.

@bandhan-majumder
Copy link
Contributor

bandhan-majumder commented Apr 2, 2025

@palisadoes

Should one be able to upload multiple attachments? Currently it's supporting a single one. If so, how the multiple attachments will be displayed? In a sliding manner from left to right?

Also, updating media files are not supported til now. Should I add them in api?

Image

@palisadoes
Copy link
Contributor

Yes to both questions

@bandhan-majumder
Copy link
Contributor

bandhan-majumder commented Apr 4, 2025

@palisadoes Alright.

@bandhan-majumder
Copy link
Contributor

bandhan-majumder commented Apr 5, 2025

@palisadoes

update:

basic functionalities are recovered

https://www.loom.com/share/8f83dc4a7f6a4dfa8e7e879476f00844

working on optimization and tests for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request GSoC Priority refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Archived in project
Status: Done
Development

No branches or pull requests

8 participants