【Hackathon 5th No.34】 为 Paddle 新增 bitwise_right_shift / bitwise_right_shift_ / bitwise_left_shift / bitwise_left_shift_ API #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuxinyi389
reviewed
Sep 28, 2023
|
|
||
| ## 命名与参数设计 | ||
|
|
||
| API的设计为`paddle.bitwise_right_shift(x, y)`，其余几个shift操作同理，其中 `x` 与 `y` 需要有相同的shape或者能够进行广播，且类型都必须为int。 |
There was a problem hiding this comment.
如何确定是算术移位还是逻辑移位
辛苦review，需要加参数设定 进行算术位移还是逻辑位移嘛，需要支持的话我修改一下？（因为我调研时看pytorch和numpy中似乎支支持算术位移，所以当时暂时没考虑逻辑位移）
There was a problem hiding this comment.
如果是参数设定，需不需要设置默认参数，默认参数设置为那种，这些内容你可以写到文档里。这次开发算术移位还是逻辑移位是同时开发支持的，jax同时支持两种，你也可以参考下。
There was a problem hiding this comment.
如果是参数设定，需不需要设置默认参数，默认参数设置为那种，这些内容你可以写到文档里。这次开发算术移位还是逻辑移位是同时开发支持的，jax同时支持两种，你也可以参考下。
OK感谢~，现增加了jax中的相关实现，加入is_arithmetic这个bool来确定是算术还是逻辑shift。
luotao1
approved these changes
Oct 9, 2023
yangguohao
pushed a commit
to yangguohao/community
that referenced
this pull request
Oct 22, 2023
…_shift_ / bitwise_left_shift / bitwise_left_shift_ API (PaddlePaddle#665)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.