[CodeStyle][ruff] fix E226, NPY201
#60245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gouzil
changed the title
E226, NPY201, PLE0704
SigureMo
previously approved these changes
Dec 21, 2023
SigureMo
reviewed
Dec 21, 2023
| self.assertEqual(out1, np.cast['int32'](self.rng1.random())) | ||
| self.assertEqual( | ||
| out1, np.asarray(self.rng1.random(), dtype=np.int32) | ||
| ) |
There was a problem hiding this comment.
2023-12-22 00:56:51 ======================================================================
2023-12-22 00:56:51 ERROR: test_static (test_seed_op.TestDropoutWithRandomSeedGenerator)
2023-12-22 00:56:51 ----------------------------------------------------------------------
2023-12-22 00:56:51 Traceback (most recent call last):
2023-12-22 00:56:51 File "/workspace/Paddle/build/test/legacy_test/test_seed_op.py", line 78, in test_static
2023-12-22 00:56:51 self.check_static_result(place=place)
2023-12-22 00:56:51 File "/workspace/Paddle/build/test/legacy_test/test_seed_op.py", line 73, in check_static_result
2023-12-22 00:56:51 out1, np.asarray(self.rng1.random(), dtype=np.int32)
2023-12-22 00:56:51 OverflowError: Python int too large to convert to C long
2023-12-22 00:56:51
2023-12-22 00:56:51 ----------------------------------------------------------------------
2023-12-22 00:56:51 Ran 3 tests in 0.056s
2023-12-22 00:56:51
2023-12-22 00:56:51 FAILED (errors=1)
看样子并不能对齐
There was a problem hiding this comment.
# Create dictionary of casting functions that wrap sequences
# indexed by type or type character
cast = _typedict()
for key in _concrete_types:
cast[key] = lambda x, k=key: array(x, copy=False).astype(k)cast 实现是这样的，直接 astype 可以么？
There was a problem hiding this comment.
cast 实现是这样的，直接 astype 可以么？
可以
gouzil
changed the title
E226, NPY201, PLE0704E226, NPY201
|
链接的话，astral-sh/ruff#7702 里的三个链接就很好了，都是非常有用的参考链接 |
Wanglongzhi2001
pushed a commit
to Wanglongzhi2001/Paddle
that referenced
this pull request
Jan 7, 2024
* fix ruff preview * fix cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
修复
E226,NPY201存量，注意这些为 preview 功能Numpy 2.0 适配情况:
np.cast->np. asarraynp.trapz->scipy.interpolate.trapezoidnp.in1d->np.isinnp.row_stack->np.vstacknp.cross-> ❓numpy.testing.assert_array_equal参数位置改变 (但是我看好像只是换了个名字 1.26、dev)numpy.testing.assert_array_almost_equal参数位置改变 (同上 1.26、dev)相关链接：