Fix issue where XRCE_DDS Bridge did not respect environment variables #25231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniaminopozzan
requested changes
Jul 16, 2025
There was a problem hiding this comment.
thanks @sansha , could you set the default value for the IP address in simulation to 127.0.0.1 to maintain back-compatibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Fixes #25188 (detailed description in that issue)
Solution
Hi, this is the PR fixing #25188 by removing the
-h 127.0.0.1flag in the launch command for the client.This fix works for me, not sure if other setups are affected.
Let me know your thoughts!
Changelog Entry
For release notes:
Alternatives
In the first commit I load the env variable explicitly but changed this to just remove the flag since I cannot test this right now. But this of course would also be an option
Test coverage
Context
Related links, screenshot before/after, video