Correct all ADSB heading related field to be in positive range #25128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Was this tested? |
|
Unfortunately, I could not test the actual SagetechMXS integration. I was only able to test using a Cube Orange Plus with an ADSB carrier board and with RingRXPro. These uAvionix systems seem to use the mavlink protocol to communicate. The prior PR already fixed it for these. This one will will make the Sagetech output consistent. I have double checked the Sagetech SDK to see that their convention is 0 due north. |
dakejahl
approved these changes
Jun 27, 2025
|
Another related PR here #24884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Additional fix for #24780 and PR #25125
Solution
Test coverage
Context
Related links, screenshot before/after, video