Add language id on beneficiary details to retrieve the language #102
Conversation
WalkthroughThe update reformats the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant IdentityService
participant Queue
participant Repository
Client->>IdentityService: createIdentity(identityDTO)
IdentityService->>Queue: synchronized access
alt Queue is empty
IdentityService->>Repository: fetch up to 10,000 unprovisioned records
Repository-->>IdentityService: return records
IdentityService->>Queue: add records
end
IdentityService->>Queue: remove first element
IdentityService->>Repository: mark as reserved, set created date if null, save
IdentityService->>Repository: mark as provisioned
IdentityService->>IdentityService: convertIdentityDTOToMBeneficiarydetail(identityDTO)
Note right of IdentityService: preferredLanguageId now mapped
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/com/iemr/common/identity/service/IdentityService.java (1)
984-1038: Map preferredLanguageId in the edit DTO converter.The
convertIdentityEditDTOToMBeneficiarydetailmethod currently mapspreferredLanguagebut notpreferredLanguageId. IfIdentityEditDTOexposes agetPreferredLanguageId()field, add analogous mapping here:beneficiarydetail.setPreferredLanguage(dto.getPreferredLanguage()); + if (dto.getPreferredLanguageId() != null) { + beneficiarydetail.setPreferredLanguageId(BigInteger.valueOf(dto.getPreferredLanguageId())); + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/iemr/common/identity/service/IdentityService.java(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (java)
- GitHub Check: Build_and_analyse
🔇 Additional comments (2)
src/main/java/com/iemr/common/identity/service/IdentityService.java (2)
1335-1335: Validate type consistency for preferredLanguageId mapping.Ensure that
dto.getPreferredLanguageId()matches the type expected byMBeneficiarydetail.setPreferredLanguageId(e.g.,BigInteger). For consistency with other ID fields (e.g.,religionId), you may need to wrap the value:-beneficiarydetail.setPreferredLanguageId(dto.getPreferredLanguageId()); +if (dto.getPreferredLanguageId() != null) { + beneficiarydetail.setPreferredLanguageId(BigInteger.valueOf(dto.getPreferredLanguageId())); +}
1047-1072: Reformatting only; no logic changes.The indentation and braces in
createIdentitywere adjusted for readability. There are no functional modifications in this block.
|
📋 Description
JIRA ID:
AMM-1388
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit
New Features
Style