chore: bump duckdb from 0.7.1 to 0.8.0 #2754
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
ref #2752 |
Bumps [duckdb](https://github.com/wangfenjin/duckdb-rs) from 0.7.1 to 0.8.0. - [Release notes](https://github.com/wangfenjin/duckdb-rs/releases) - [Commits](duckdb/duckdb-rs@v0.7.1...v0.8.0) --- updated-dependencies: - dependency-name: duckdb dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/cargo/duckdb-0.8.0
branch
from
0a569d4 to
e41c60c
Compare
|
I am surprised that DuckDB 0.8 was able to pass the test. Was this expected? |
Ummm, no, how did that happen :) |
|
The main reason we didn't merge was because it broke our tests. But it's very weird that it now doesn't break our tests! I checked that at least the tests fail when the result is changed, so the tests are still working |
|
The commit at #2601 also passes, actually |
|
8b24303 fails, as expected. I couldn't see the different at first glance. It does seem like tests are running — changing a snapshot does make it break. So it's unclear what's going on... |
As part of debugging PRQL#2754, there are a few places the test can return early etc. While they're not the cause of the issue, it's worth removing them anyway
|
OK, so this is amusing — I don't think there was ever an issue about sorting and nulls. The sort column in the relevant query doesn't have any nulls. So all of that discussion was just LARPing... The reason the test now passes is because in #2684, we changed the query to the one that works with duckdb 0.8.0. So I'm guessing this was something to do with that. (Though I'm not 100% sure about this — I implement Regardless, I'm signing off for the eve. I don't think the nulls issue is urgent any longer. And it's a good reminder to ensure the thing we're working on is actually solving the relevant problem. |
|
Hahaha, we were solving a real issue, but the cause was something completely unrelated :D |
Bumps duckdb from 0.7.1 to 0.8.0.
Release notes
Sourced from duckdb's releases.
Commits
cfda58bupgrade to 0.8.0 (#160)6795035Update arrow requirement from 38 to 39 (#158)948b879build loadable in test (#154)6b86026Update arrow requirement from 37 to 38 (#152)fb9289bUpdate syn requirement from 1.0.95 to 2.0.15 (#153)b310e9bbuild loadable ext (#149)80a492cUpdate arrow requirement from 36 to 37 (#146)52e8c0cUpdate bindgen requirement from 0.64 to 0.65 (#147)5b03df8Add more arrow examples (#142)7ceaa5efeat: make record_batch_to_chunk public (#144)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)