-
Notifications
You must be signed in to change notification settings - Fork 228
into
semantics as transform?
#4291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Discussion for adding #2427 mentions benefit of scanning only the first keyword in the line to find all variable declarations, which would be against this. I'm not sold on making let a = (
from x
into b
) This feels very wrong. To get the proposed results, we could just add additional syntax that would allow top-level expression to have I would be -0 on this compromise. It feels like the best solution here would be to just provide good errors when the |
My main point here is that saying "within a pipeline, a pipe character is the same as a newline — except in the case of Ref these docs:
A level down:
Yes fair! Though:
|
Error message not great but can be improved separately. Closes PRQL#4291, I think without doing anything controversial
Thanks to @broneill — full details at #4277 (reply in thread)
I had been thinking of
into
as a transform — so following a pipe (either a|
or new line).Currently, quoting from the discussion linked above
valid, correctly so
valid, but incorrectly so — I think should be invalid
invalid, but incorrectly so — I think should be valid
The text was updated successfully, but these errors were encountered: