Add cbatch/calloc/crun --mem-per-cpu

[1daidai1]

Summary by CodeRabbit

• New Features
  • Added a command-line option to specify maximum memory per CPU with unit support (GB, MB, KB, Bytes; default MB) across multiple commands.
  • Enforced mutual exclusivity between the memory per CPU option and the total memory option.
• Bug Fixes
  • Improved error handling for invalid memory size inputs in the memory per CPU option.
• Other Changes
  • Extended task definitions to include a memory per CPU field.

[coderabbitai]

Walkthrough

A new mem-per-cpu command-line flag was introduced to the calloc, cbatch, and crun commands, allowing users to specify a maximum memory per CPU value with unit parsing. This flag is mutually exclusive with the existing mem flag. The value is parsed and assigned to the MemPerCpu field in task structures. The protobuf TaskToCtld message was updated to include a mem_per_cpu field.

Changes

File(s)	Change Summary
internal/calloc/CmdArgParser.go internal/cbatch/CmdArgParser.go internal/crun/CmdArgParser.go	Added mem-per-cpu command-line flag; registered flag; enforced mutual exclusion with mem flag.
internal/calloc/calloc.go internal/cbatch/cbatch.go internal/crun/crun.go	Parsed and assigned mem-per-cpu value to MemPerCpu field in task objects; added error handling for parsing.
protos/PublicDefs.proto	Added mem_per_cpu field to TaskToCtld protobuf message.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI (calloc/cbatch/crun)
    participant Util
    participant Task

    User->>CLI (calloc/cbatch/crun): Run with --mem-per-cpu flag
    CLI (calloc/cbatch/crun)->>Util: Parse mem-per-cpu value (e.g., "2GB")
    Util-->>CLI (calloc/cbatch/crun): Return value in bytes or error
    alt Parse success
        CLI (calloc/cbatch/crun)->>Task: Set MemPerCpu field
    else Parse failure
        CLI (calloc/cbatch/crun)->>User: Log error, exit with argument error
    end

Loading

Poem

A flag for memory, per CPU it goes,
Now calloc, cbatch, and crun all know!
With units to parse, and errors to catch,
Mutually exclusive, so bugs won’t hatch.
Protobufs updated, the fields align—
Memory per core, all working fine!
🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7e253e and 04bf4da.

📒 Files selected for processing (1)

• internal/crun/crun.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• internal/crun/crun.go

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[1daidai1]

PKUHPC/CraneSched#451

[L-Xiafeng]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.