Skip to content

Fix stamp.sh error calling git #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025
Merged

Conversation

kahlkevin
Copy link
Contributor

  • Problem: $1 is empty string inside shell function "timestamps"
  • Solution: Use $list global computed previously

@kahlkevin
Copy link
Contributor Author

Or, instead was the intent that the timestamp match the most recent commit on a per file basis?

If so, I can patch this pull request (or submit a new one) to change $list to $i. Please advise if this is the maintainers' preference.

(Either way, the current $1 is incorrect and leads to error output during make)

@larsbrinkhoff
Copy link
Member

Yes, I think $i was intended. Thanks, good catch!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
 - Problem: $1 is empty string inside shell function "timestamps"
 - Solution: Use $i loop variable (probably originally intended)
@kahlkevin
Copy link
Contributor Author

kahlkevin commented Apr 12, 2025

Yes, I think $i was intended. Thanks, good catch!

Okay, I've made the change here (via rebase/force-push so we still only have a single commit). It uses $i now, and I agree this seems more likely to have been original intent.

Once you're happy with validation, I look forward to your approval and completion of the pull request.

@larsbrinkhoff
Copy link
Member

Merged, thanks!

@larsbrinkhoff larsbrinkhoff merged commit f46544d into PDP-10:master Apr 13, 2025
17 of 18 checks passed
@kahlkevin kahlkevin deleted the fix-stamp-bug branch April 13, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants