Optimize Formatter for 90% less memory usage and 15-30% faster execution #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've optimized the Formatter class to significantly improve its memory efficiency and performance
Main Improvements
Poolable<T>
system that recyclesElement
,Token
,Lexer
,Entry
, andElementTreeBuilder
objectsLexer
state machine with a more efficient enum-based implementationStringBuilder
pooling withinToTreeFormat()
Benchmark Results
Using this crude benchmark script on both the original and optimized versions:
Before vs After (100 iterations on 2053 test inputs):
Execution Time (lower is better)
Memory Usage (lower is better)