Tags automatic sorting problem

[yqzhen1990]

Describe the bug

After selecting tags in order, save and refresh the edit page, the tags will be automatically sorted

Orchard Core version

2.1.5

Expected behavior

Prevent tags automatic sorting, or it will be saved in the order of automatic sorting, which is unexpected.

Logs and screenshots

This is the order I want to save, and it works：

This is the automatic sorting order, when I reopen to edit the content item:

If I want to sort them in the order I want, I have to delete all the tags and reselect them. Otherwise, when I save, the tags will be saved in the order they were automatically sorted.

[hishamco]

IMHO tags should not be sorted, it should depend on the user input. On the site we could sort them if we want

[yqzhen1990]

IMHO tags should not be sorted, it should depend on the user input. On the site we could sort them if we want

Yes , you're right.

[yqzhen1990]

IMHO tags should not be sorted, it should depend on the user input. On the site we could sort them if we want

The problem is that when I enter the edit page, the tags are automatically sorted.

[hishamco]

Do you want to give it a try and fix the issue by submitting a PR?

[yqzhen1990]

Do you want to give it a try and fix the issue by submitting a PR?

I have fixed it, but I am not very clear about the PR submission process of OrchardCoreCMS, can you help me with it?

using System.Text.Json.Nodes;
using OrchardCore.ContentManagement;
using OrchardCore.Taxonomies.Fields;
using OrchardCore.Taxonomies.ViewModels;

namespace OrchardCore.Taxonomies.Drivers;

public static class TaxonomyFieldDriverHelper
{
    /// <summary>
    /// Populates a list of <see cref="TermEntry"/> with the hierarchy of terms.
    /// The list is ordered so that roots appear right before their child terms.
    /// </summary>
    public static void PopulateTermEntries(List<TermEntry> termEntries, TaxonomyField field, IEnumerable<ContentItem> contentItems, int level)
    {

        foreach (var selectedTermContentItemId in field.TermContentItemIds)
        {
            if(contentItems.Any(x => x.ContentItemId == selectedTermContentItemId))
            {
                var contentItem = contentItems.First(x => x.ContentItemId == selectedTermContentItemId);

                var children = Array.Empty<ContentItem>();

                if (((JsonObject)contentItem.Content)["Terms"] is JsonArray termsArray)
                {
                    children = termsArray.ToObject<ContentItem[]>();
                }

                var termEntry = new TermEntry
                {
                    Term = contentItem,
                    ContentItemId = contentItem.ContentItemId,
                    Selected = field.TermContentItemIds.Contains(contentItem.ContentItemId),
                    Level = level,
                    IsLeaf = children.Length == 0
                };

                termEntries.Add(termEntry);

                if (children.Length > 0)
                {
                    PopulateTermEntries(termEntries, field, children, level + 1);
                }
            }

        }
    }
}

[hishamco]

1. Fork the Orchard Core repo
2. Clone the forked repo
3. Create a Git branch
4. Apply your changes
5. Submit a PR

[yqzhen1990]

1. Fork the Orchard Core repo
2. Clone the forked repo
3. Create a Git branch
4. Apply your changes
5. Submit a PR

I've done with that.
Thanks for your help!

[Piedone]

See https://docs.orchardcore.net/en/latest/contributing/contributing-code/.

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.