Is liquid gone case insenitive from 2.0 to 2.1.4?

[bashuss]

Describe the bug

After upgrade from 2.0 to 2.1.4, my liquid templates seem to be case insensitive. I did not check all code yet, but it is obvious with the culture selector. See code excerpt below.
If this is a common thing, it can cause a lot of trouble.

Orchard Core version

2.1.4

To Reproduce

   {%- assign cultures = Culture | supported_cultures -%}
   {%- for culture in cultures -%}
        {%- assign culturename = culture.Name -%}
        {%- assign nname = culturename | split: " " -%}
        {%- if culturename != Culture.Name  -%}
        <!-- UnEqual
            Culture: {{ Culture.Name }}
            culturename : {{ culturename }}
            nname : {{ nname | json |raw }}
        -->
        <li class="nav-link"><a class="dropdown-item" href="{{culturename | switch_culture_url }}">{{nname[0] | t }}</a></li>
        {%- else -%}
        <!-- Equal
            Culture: {{ Culture.Name }}
            culturename : {{ culturename }}
            nname : {{ nname | json |raw }}
        -->
        <li class="nav-link"><span class="culture-select-text"><i class="fas fa-check"></i> {{ nname[0] | t }}</span></li>
        {% endif -%}
    {%- endfor -%}

1. Use the code above in a template
2. adjust OC 2.1.4 for at least two supported cultures
3. Display a content item with the template
4. Check the rendered code part: currently it is

       <!-- Equal
            Culture: de-DE
            culturename : de-DE
            nname : ["de-DE"]
        -->
        <li class="nav-link"><span class="culture-select-text"><i class="fas fa-check"></i> de-DE</span></li>
       <!-- Equal
            Culture: en
            culturename : en
            nname : ["en"]
        -->
        <li class="nav-link"><span class="culture-select-text"><i class="fas fa-check"></i> en</span></li>

Expected behavior

At (4.) the result was like this in 2.0

      <!-- Equal
           Culture: de-DE
           culturename : de-DE
           nname : ["de-DE"]
       -->
       <li class="nav-link"><span class="culture-select-text"><i class="fas fa-check"></i> de-DE</span></li>
     <!-- UnEqual
           Culture: de-DE
           culturename : en
           nname : ["en"]
       -->
       <li class="nav-link"><a class="dropdown-item" href="/t4h/RedirectToLocalizedContent?targetCulture=en">en</a></li>

Logs and screenshots

[sebastienros]

Your repro is showing that culture is used instead of Culture in the Culture.Name call, so the simpler repro is

{%- assign cultures = Culture | supported_cultures -%}
   {%- for culture in cultures -%}
        {{ Culture.Name }}
   {%- endfor -%}

The issue is in this PR, I will fix it

This can be mitigated in Orchard by forcing the comparer on the TemplateOptions property. The current default is wrong.

Note to myself:

• Scope should take a ctor with the StringComparer
• TemplateOptions should default to case sensitive

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.