Skip to content

[#564] Remove divider if outline effect is active in RadioItem component #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2025
Merged

[#564] Remove divider if outline effect is active in RadioItem component #570

merged 4 commits into from
Apr 1, 2025

Conversation

ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Mar 28, 2025 •
edited by pylapp
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#564

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibility review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@ludovic35 ludovic35 linked an issue Mar 28, 2025 that may be closed by this pull request
[Component Update] In the RadioControlItem, do not show the divider if the Contolitem is outlined #564
Closed
8 tasks
@ludovic35 ludovic35 marked this pull request as ready for review March 28, 2025 22:11
@ludovic35 ludovic35 requested a review from pylapp as a code owner March 28, 2025 22:11
@pylapp pylapp self-assigned this Mar 31, 2025
pylapp
pylapp requested changes Mar 31, 2025
View reviewed changes
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Juste des fautes de saisie, le fonctionnel est bon sinon :)

@pylapp pylapp force-pushed the 564-component-update-in-the-radiocontrolitem-do-not-show-the-divider-if-the-contolitem-is-outlined branch from 3c140f4 to bc2c459 Compare April 1, 2025 07:57
@pylapp pylapp merged commit df06b03 into develop Apr 1, 2025
7 of 9 checks passed
@pylapp pylapp deleted the 564-component-update-in-the-radiocontrolitem-do-not-show-the-divider-if-the-contolitem-is-outlined branch April 1, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pylapp pylapp pylapp requested changes

Assignees

@pylapp pylapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component Update] In the RadioControlItem, do not show the divider if the Contolitem is outlined
2 participants
@ludovic35 @pylapp