Skip to content

Fix a11y audit: headings on left menu and link to design doc #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Fix a11y audit: headings on left menu and link to design doc #2859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26e9fb
Fix a11y audit: link Visit system.design.orange.com + titles on left …
hannahiss Feb 3, 2025
6652d80
Merge branch 'main' into main-his-2667-a11y-audit-last-fxes
hannahiss Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions site/assets/scss/_sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
.bd-links-heading {
color: var(--bs-emphasis-color);

@include media-breakpoint-down(lg) {
font-size: .875rem;
}

// Boosted mod
svg {
font-size: 1.5625rem;
Expand Down
3 changes: 2 additions & 1 deletion site/layouts/_default/docs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{{ define "body_override" }}<body{{ if (eq .Page.Params.toc true) }} data-bs-spy="scroll" data-bs-target="#TableOfContents"{{ end }}>{{ end }}
{{ define "main" }}
<div class="container-xxl bd-gutter mt-3 my-md-4 bd-layout">
<nav class="bd-sidebar" aria-label="Docs navigation">
<nav class="bd-sidebar" aria-labelledby="docs-nav">
<h1 id="docs-nav" class="visually-hidden">Docs navigation</h1>
<div class="offcanvas-lg offcanvas-start" tabindex="-1" id="bdSidebar" aria-labelledby="bdSidebarOffcanvasLabel">
<div class="offcanvas-header border-bottom">
<h5 class="offcanvas-title" id="bdSidebarOffcanvasLabel">Browse docs</h5>
Expand Down
2 changes: 1 addition & 1 deletion site/layouts/_default/single.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ <h1 class="display-1">{{ .Title | markdownify }}</h1>
</div>
{{ else if eq .Title "Orange Design System for web" -}}
<div class="d-flex flex-column flex-sm-row">
<a href="{{ .Site.Params.ods.web }}" class="btn btn-primary" aria-label="Visit Orange Design System for web at system.design.orange.com" title="Visit Orange Design System for web at system.design.orange.com" target="_blank" rel="noopener">Visit system.design.orange.com</a>
<a href="{{ .Site.Params.ods.web }}" class="btn btn-primary" title="Visit system.design.orange.com" target="_blank" rel="noopener">Visit system.design.orange.com</a>
</div>
{{- end }}
</div>
Expand Down
4 changes: 2 additions & 2 deletions site/layouts/partials/docs-sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@

{{- if $group.pages }}
<li class="bd-links-group py-2">
<strong class="bd-links-heading d-flex w-100 align-items-center fw-semibold">
<h2 class="display-5 mb-0 bd-links-heading d-flex w-100 align-items-center fw-semibold">
{{- if $group.icon }}
<svg class="bi me-1"{{- if $group.icon_color }} style="color: var(--bs-{{ $group.icon_color }});"{{- end }} aria-hidden="true"><use xlink:href="#{{ $group.icon }}"></use></svg>
{{- end }}
{{ $group.title }}
</strong>
</h2>

<ul class="list-unstyled fw-normal mt-1 pb-2 small">
{{- range $doc := $group.pages -}}
Expand Down
2 changes: 1 addition & 1 deletion site/layouts/partials/home/orange-design-system.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ <h2 class="mb-3 fw-semibold lh-sm">Orange Design System for web</h2>
Streamline your workflow and improve experience consistency with this cross-platform, scalable and inspiring design system. Designers, developers, marketers and partners, start your digital creations from the ready-to-use resources here!
</p>
<p class="d-flex flex-column lead fw-normal mb-0">
<a href="{{ .Site.Params.ods.web }}" class="icon-link icon-link-hover fw-semibold" target="_blank" rel="noopener">
<a href="{{ .Site.Params.ods.web }}" class="icon-link icon-link-hover fw-semibold" target="_blank" rel="noopener" title="Visit system.design.orange.com">
Visit system.design.orange.com
<svg class="bi" aria-hidden="true"><use xlink:href="#arrow-right"></use></svg>
</a>
Expand Down
Loading