Docs: enhance doc for Solaris icons #2075
Conversation
# Conflicts: # site/layouts/shortcodes/orange-footer.html
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hannahiss
added
v5
📖 documentation
This comment was marked as resolved.
This comment was marked as resolved.
|
Kudos, SonarCloud Quality Gate passed!
|
This comment was marked as resolved.
This comment was marked as resolved.
|
FYI, tackled one of the sub-tasks to save you some time via be5e2e0. If the rest is too long to do, or not prioritized, this modification could be extracted from this PR to be merged right away. |
|
Kudos, SonarCloud Quality Gate passed!
|
# Conflicts: # site/content/docs/5.3/components/tooltips.md # site/static/docs/5.3/assets/img/boosted-sprite.svg
… documentation on SVGs accessibility
… main-his-solaris-icons-doc
There was a problem hiding this comment.
Great job @hannahiss!
Some minor suggestions, modifications and questions, and we'll be good to go!
| </symbol> | ||
| <symbol fill="currentColor" viewBox="0 0 24 24" id="danger"> | ||
| <path d="m21.832 17.617-7.886-13.5a2.256 2.256 0 0 0-3.892 0L2.186 17.583v.002l-.02.032h.001A2.248 2.248 0 0 0 4.113 21h15.773a2.25 2.25 0 0 0 1.946-3.383Zm-6.88-.714a.823.823 0 0 1-1.163 0l-1.93-1.932-1.93 1.932a.823.823 0 0 1-1.174-1.155l.01-.01 1.93-1.93-1.861-1.863a.823.823 0 0 1 1.163-1.164l1.862 1.862 1.861-1.862a.823.823 0 0 1 1.174 1.153l-.01.011-1.862 1.862 1.93 1.931a.824.824 0 0 1 0 1.165Z"/> | ||
| <symbol fill="currentColor" viewBox="0 0 1000 1000" id="error-severe"> |
There was a problem hiding this comment.
I can see a lot of modifications here to have viewBox="0 0 1000 1000" versions. Don't we need to update the warning, success, error, etc. icons in _variables.scss? (e.g. $warning-icon-filled etc.)
There was a problem hiding this comment.
Discussed together: not to be modified for now because the risk is too big to make a mistake and the difference is tiny...
The differences between Boosted and designs (V6 kit) should be tracked in an issue though (in particular paddings that do not include borders)
There was a problem hiding this comment.
Yep, let's create a dedicated issue after having merged this PR to tackle it for the next release
Co-authored-by: Julien Déramond <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
Note: Please transform
- [ ]into- (NA)in the description when things are not applicableRelated issues
Has been splitted from #1929
Should be merged after #2030 in order to have a complete functionality for SVG sprite icons with text color utilities and a good documentationShould be merged after #2240 in order to have new warning icon everywhereDescription
In icons documentation (extend > icons):
In Tooltip component (components > tooltips):
.text-infofor tooltip icon and remove color from Boosted spriteIn tables (content > tables):
Everywhere:
Change icon boosted-cross.svg with the one from Icons finder
Remove icons doc from utilities/colors and point to icons documentation instead
Motivation & Context
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge