Skip to content

Cause _addSigners to revert if it triggers a totalWeight overflow #5790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2025
Merged

Cause _addSigners to revert if it triggers a totalWeight overflow #5790

merged 3 commits into from
Jul 9, 2025

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jul 8, 2025

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@Amxx Amxx added this to the 5.4 milestone Jul 8, 2025
@Amxx Amxx requested a review from a team as a code owner July 8, 2025 14:02
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: cbdd1f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx requested a review from ernestognw July 8, 2025 14:02
Amxx
Amxx commented Jul 8, 2025
View reviewed changes
@Amxx Amxx merged commit ba35d58 into OpenZeppelin:master Jul 9, 2025
20 checks passed
@Amxx Amxx deleted the fix/addSigner-overflow branch July 9, 2025 07:08
Amxx added a commit that referenced this pull request Jul 9, 2025
@Amxx
Cause _addSigners to revert if it triggers a totalWeight overflow (#5790
2e152ba 
)

Signed-off-by: Hadrien Croubois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @ernestognw