Skip to content

Optimize MerkleTree for loops by using uint256 iterators #5415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Optimize MerkleTree for loops by using uint256 iterators #5415

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85887fa
Optimize `MerkleTree` for loops by using `uint256` iterators
heueristik Jan 6, 2025
f8240b4
chore: add changeset entry
heueristik Jan 6, 2025
d0e791e
Delete .changeset/three-news-jump.md
ernestognw Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/utils/structs/MerkleTree.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ library MerkleTree {

// Build each root of zero-filled subtrees
bytes32 currentZero = zero;
for (uint32 i = 0; i < treeDepth; ++i) {
for (uint256 i = 0; i < treeDepth; ++i) {
Arrays.unsafeAccess(self._zeros, i).value = currentZero;
currentZero = fnHash(currentZero, currentZero);
}
Expand Down Expand Up @@ -143,7 +143,7 @@ library MerkleTree {
// Rebuild branch from leaf to root
uint256 currentIndex = index;
bytes32 currentLevelHash = leaf;
for (uint32 i = 0; i < treeDepth; i++) {
for (uint256 i = 0; i < treeDepth; i++) {
// Reaching the parent node, is currentLevelHash the left child?
bool isLeft = currentIndex % 2 == 0;

Expand Down
Loading