-
Notifications
You must be signed in to change notification settings - Fork 12.1k
Rename toString to toStringSigned #4330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
frangio
merged 10 commits into
OpenZeppelin:master
from
balajipachai:string-tostring-compile-with-integer-literal
Jun 19, 2023
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
76f5701
feat: adds toStringSigned & its tests
balajipachai 27c7c25
fix: removes StringsMock & updates tests
balajipachai fa07c12
Merge branch 'master' into string-tostring-compile-with-integer-literal
balajipachai 2d9a47f
fix: implements the reviewed changes
balajipachai 016925f
Merge branch 'master' into string-tostring-compile-with-integer-literal
balajipachai c6240a6
Update contracts/utils/Strings.sol
balajipachai 38aa0de
Update test/utils/Strings.test.js
balajipachai b574b0a
Update test/utils/Strings.test.js
balajipachai 6814161
feat: adds changeset
balajipachai 2a39ea1
Update .changeset/tasty-tomatoes-turn.md
balajipachai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// SPDX-License-Identifier: MIT | ||
|
||
pragma solidity ^0.8.19; | ||
|
||
import "../utils/Strings.sol"; | ||
|
||
contract StringsMock { | ||
string public integerLiteralConversion; | ||
|
||
constructor() { | ||
integerLiteralConversion = string.concat( | ||
Strings.toStringSigned(100), | ||
" Integer literal conversion successful!" | ||
); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.