Add WebAuthn library and SignerWebAuthn #117
Open
+827
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestognw
changed the title
Co-authored-by: Ernesto García <[email protected]>
Co-authored-by: Arr00 <[email protected]>
Co-authored-by: Gonzalo Othacehe <[email protected]> Co-authored-by: Gonzalo Othacehe <[email protected]>
Co-authored-by: Arr00 <[email protected]> Co-authored-by: Gonzalo Othacehe <[email protected]>
Co-authored-by: ernestognw <[email protected]>
Co-authored-by: ernestognw <[email protected]>
arr00
reviewed
Jun 4, 2025
3 tasks
arr00
reviewed
Jun 10, 2025
Comment on lines
+217
to
+219
| function validateBackupEligibilityAndState(bytes1 flags) internal pure returns (bool) { | ||
| return (flags & AUTH_DATA_FLAGS_BE) != 0 || (flags & AUTH_DATA_FLAGS_BS) == 0; | ||
| } |
There was a problem hiding this comment.
Would prefer consistency on how we are checking the value of a bit
flags & AUTH_DATA_FLAGS_BE) != 0 or flags & AUTH_DATA_FLAGS_BE) == AUTH_DATA_FLAGS_BE
Otherwise looks good
Amxx
reviewed
Jun 11, 2025
test/helpers/signers.js
Outdated
There was a problem hiding this comment.
I'm wondering, is there a WebAuthn library/package we would be using ?
There was a problem hiding this comment.
Yes, these has been around since forever: https://viem.sh/account-abstraction/accounts/webauthn/createWebAuthnCredential#createwebauthncredential
There was a problem hiding this comment.
Goes well with pimlico too:
https://docs.pimlico.io/references/permissionless/how-to/signers/passkey-server#install-the-required-packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements WebAuthn authentication verification for smart contracts using P256 signatures as an alternative to traditional secp256k1 ECDSA. This library enables strong authentication through WebAuthn Level 2 standard compliance.
Includes 3 verification levels:
verifyMinimal: Essential cryptographic checksverify: Standard verification with user presenceverifyStrict: Enhanced security with user verification and backup state checks