Skip to content

Error : issue with Good samaritan contract #782

@18121A05L2

Description

@18121A05L2

Hi Team, i was facing this issue when compiling the good samaritan contract

import "https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/Address.sol";

I was using this openzeppelin , however, the open zeppelin version - import "openzeppelin-contracts-08/utils/Address.sol"; provided in that challenge was no longer maintained and also I was not able to find too

Deprecation - https://github.com/OpenZeppelin/openzeppelin-contracts/blob/0a77e54c307d9becf0473b73541c4f9d3b2743a3/CHANGELOG.md?plain=1#L180

if this is a valid issue, can I work on this one ?


Image

NOTE : and also adding this extra point in the success message

-> if we are using a try catch , and if that external call fails , the state that has been updated in that external call will be reverted and in catch it will all be like the state how it was before the external call in the try is triggered

cause I have used a state inside of my INotifyable contract and have tried to figure out why I was failing 😅 , and later i have realized this when I have added logs in my contract

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions