Skip to content

Update to Solidity 0.5 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
paulinablaszk opened this issue Apr 25, 2019 · 4 comments
Closed

Update to Solidity 0.5 #117

paulinablaszk opened this issue Apr 25, 2019 · 4 comments
Assignees
@paulinablaszk

Comments

@paulinablaszk
Copy link
Contributor

Solidity update to version 0.5 has brought breaking changes. We have to update all contracts to compile with > 0.5
@ghost
Copy link

ghost commented Apr 26, 2019

It also wouldn't be a bad idea to write tests for the Solidity code either. It's will be good for testing changes down the road.

@ghost
Copy link

ghost commented Apr 27, 2019

Do we have a specific Solidity 5 version that we want to use?

@paulinablaszk
Copy link
Contributor Author

@frederickalcantara What kind of test do you think about?
I've started with "pragma solidity ^0.5.0" because it is actually used in Openzeppelin-solidity and ZeppelinOS smart contracts

@ghost
Copy link

ghost commented Apr 27, 2019

Im looking up different types of testing conventions. But I know that TDD is the better way to go in long term, reduces bugs & prevents headaches down the road.

paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue Apr 30, 2019
@paulinablaszk
Update smart contracts to Solidity 0.5 OpenZeppelin#117
994e98c
@paulinablaszk paulinablaszk mentioned this issue Apr 30, 2019
Closed
39 tasks
@paulinablaszk paulinablaszk self-assigned this Apr 30, 2019
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 12, 2019
@paulinablaszk
Solidity 0.5 contracts update OpenZeppelin#117
fba32fa
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 13, 2019
@paulinablaszk
Solidity 0.5 contracts update (part3) OpenZeppelin#117
15d4204
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 15, 2019
@paulinablaszk
Fallback and FallbackFactory update OpenZeppelin#117
980cfd6
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 21, 2019
@paulinablaszk
Correct types conversion OpenZeppelin#117
1796656
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 21, 2019
@paulinablaszk
Correct type conversion OpenZeppelin#117
0b44af4
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 21, 2019
@paulinablaszk
Use address payable owner instead of Ownable OpenZeppelin#117
cf3faa1
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 21, 2019
@paulinablaszk
Solidity 0.5 contracts update OpenZeppelin#117
72445cc
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 21, 2019
@paulinablaszk
Merge branch 'master' into solidity-0.5-OpenZeppelin#117
8b7f7b8
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 23, 2019
@paulinablaszk
Update attack contracts OpenZeppelin#117
7fd6e35
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 23, 2019
@paulinablaszk
Change parameter in validateInstance function OpenZeppelin#117
426e2e1
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 30, 2019
@paulinablaszk
Update web3 to 1.0.0 OpenZeppelin#117
b10e50d
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 30, 2019
@paulinablaszk
Update test lib. to openzeppelin-test-helpers OpenZeppelin#117
2f084fd
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue May 30, 2019
@paulinablaszk
Tests update OpenZeppelin#117
2c75d76
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue Jun 17, 2019
@paulinablaszk
Update Fallback test OpenZeppelin#117
0ead047
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue Jun 19, 2019
@paulinablaszk
Token test update OpenZeppelin#117
ac50026
paulinablaszk added a commit to paulinablaszk/ethernaut that referenced this issue Jul 18, 2019
@paulinablaszk
Merge branch 'master' into solidity-0.5-OpenZeppelin#117
1d6eee6
@abcoathup abcoathup mentioned this issue Aug 1, 2019
Open
spalladino added a commit that referenced this issue Nov 19, 2019
@spalladino
Update to solidity 0.5 (#151)
ee3ba21 
* Update smart contracts to Solidity 0.5 #117

* Solidity 0.5 contracts update #117

* Solidity 0.5 contracts update (part3) #117

* Fallback and FallbackFactory update #117

* Update contracts/levels/Fallback.sol

Co-Authored-By: Francisco Giordano <[email protected]>

* Correct types conversion #117

* Correct type conversion #117

* Use address payable owner instead of Ownable #117

* Solidity 0.5 contracts update #117

* Update attack contracts #117

* Change parameter in validateInstance function #117

* EthernautTestes update

* Update web3 to 1.0.0 #117

* Update test lib. to openzeppelin-test-helpers #117

* Tests update #117

* Update Fallback test #117

* Token test update #117

* Update Force test

* Update King test

* Update Vault test

* Update Locked test

* Delegation test update

* Update Preservation test

* Correct RecoveryFactory to use big endian during conversion

* Recovery test update

* Update denial test

* Update Privacy test

* Update TestUtils

* Update conversions in gateThree modifier

* Delete view from Elevator interface

* Update Fallouts to pass tests

* Update ALienCodex (delete first part)

* Update createLevelInstance  to filter event

* Delete "Locked" level

* Update dependencies

* Add testing dependency

* Update dependencies

* Remove uglify due to incompatibilities with babel
CeliktepeMurat pushed a commit to CeliktepeMurat/ethernaut that referenced this issue Jan 9, 2023
@spalladino @CeliktepeMurat
Update to solidity 0.5 (OpenZeppelin#151)
edf0e0b 
* Update smart contracts to Solidity 0.5 OpenZeppelin#117

* Solidity 0.5 contracts update OpenZeppelin#117

* Solidity 0.5 contracts update (part3) OpenZeppelin#117

* Fallback and FallbackFactory update OpenZeppelin#117

* Update contracts/levels/Fallback.sol

Co-Authored-By: Francisco Giordano <[email protected]>

* Correct types conversion OpenZeppelin#117

* Correct type conversion OpenZeppelin#117

* Use address payable owner instead of Ownable OpenZeppelin#117

* Solidity 0.5 contracts update OpenZeppelin#117

* Update attack contracts OpenZeppelin#117

* Change parameter in validateInstance function OpenZeppelin#117

* EthernautTestes update

* Update web3 to 1.0.0 OpenZeppelin#117

* Update test lib. to openzeppelin-test-helpers OpenZeppelin#117

* Tests update OpenZeppelin#117

* Update Fallback test OpenZeppelin#117

* Token test update OpenZeppelin#117

* Update Force test

* Update King test

* Update Vault test

* Update Locked test

* Delegation test update

* Update Preservation test

* Correct RecoveryFactory to use big endian during conversion

* Recovery test update

* Update denial test

* Update Privacy test

* Update TestUtils

* Update conversions in gateThree modifier

* Delete view from Elevator interface

* Update Fallouts to pass tests

* Update ALienCodex (delete first part)

* Update createLevelInstance  to filter event

* Delete "Locked" level

* Update dependencies

* Add testing dependency

* Update dependencies

* Remove uglify due to incompatibilities with babel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulinablaszk paulinablaszk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulinablaszk @hensha256