Skip to content

Change: disabled_platforms/length is now bitmask(1-8)>>1 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2022
Merged

Change: disabled_platforms/length is now bitmask(1-8)>>1 #264

merged 1 commit into from
Sep 3, 2022
+11 −3

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Sep 3, 2022

Writing bitmask(2) to disable platform/length 3 is not very intuitive. Instead we expect the user will write bitmask(3) and we shift the result.

frosch123
frosch123 approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@frosch123 frosch123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe drop the ">> 1" from the commit message.
The user now enters "bitmask(1-8)".

@glx22 glx22 merged commit 121c207 into OpenTTD:master Sep 3, 2022
@glx22 glx22 deleted the disabled_platforms_length branch September 3, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frosch123 frosch123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glx22 @frosch123