Prevent Crash in Object Detector and Tracker effects (due to child clip id) #5205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data tuple for the current selected property label: Setnry reported this error: OPENSHOT-43.
…data tuple for the current selected property label: Sentry reported this error: OPENSHOT-43. This also fixes a regression related to updating ObjectDetector and Tracker objects.
…e of ENABLE_PLAYBACK_CACHING. For example, sometimes we have already disabled this setting before changing the timeline data - and we would like it to stay disabled until further notice. This method was accidentally re-enabling the caching when we were not expecting it to.
…hods - to ignore when an object_id is not found, or a clip has no 'objects' dict
…/ effect, and allow setting of the initial value to work correctly.
…or pickers, and other property dialog editors - to correctly update the JSON without destroying certain data or "objects"
…context menus in the Property dialog - for example, clips with no effects, or clips with no tracking data, etc... Also, making things more consistent with parent folders in context menus (None, Clips, Tracked Objects)
…simpler, and more efficient. This solves a bug on Windows also, where file paths were not matching correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been many bad recent regressions which have broken our Object Detector and Tracker effects - mostly related to optimizations before we save project JSON - accidentally deleting some bits that are important, such as our "tracked" objects, among other Property window errors (missing or invalid child clip ids or parent ids), etc...
This PR fixes all of this, and protects the code much better against missing or invalid IDs.