Fixing libopenshot version warning message + Sentry.io fixes #4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Frank Dana <[email protected]>
json_data: Logs, relative path fix - Lots of log.debug() messages added - project.current_filepath doesn't have a value for new projects, at the point we're saving, so use the 'new_project_assets' context path instead.
Don't make paths to other drives relative
* added guards where we were getting exceptions * added guards where we were getting exceptions * Used setdeafult for safe appending * Made update_color safer while I'm here
…cess app.show_errors in the exception handler, since app fails to initialize.
…ions (Sentry.io errors)
…till possible to change animation interpolations, remove keyframes, etc... on a color keyframe. Double clicking the color still works the same though.
Sentry fixes
…error, since this is a perfectly valid outcome (with the wrong version of blender)
…hot/openshot-qt into fixing-libopenshot-warning-message � Conflicts: � src/classes/json_data.py
jonoomph
commented
Aug 22, 2021
| @@ -185,8 +185,6 @@ def check_libopenshot_version(self, info, openshot): | |||
| }, | |||
| level="error", | |||
| )) | |||
| raise RuntimeError( | |||
There was a problem hiding this comment.
This was preventing the OpenShotApp from initializing
jonoomph
commented
Aug 22, 2021
| try: | ||
| app = OpenShotApp(argv) | ||
| except Exception: | ||
| app.show_errors() |
There was a problem hiding this comment.
app was never initialized in the except block... and below a few lines, we call app.gui() which displays the errors... if a gui is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some issues in the release branch, found in my testing and in Sentry.io (with some of our 2.6.0 testers)