Don't kill the WebView on aboutToQuit #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out, PyQt5's implementation of QApplication emits that signal every time the user types anything on the input line, when running Python interactively.
ferdnyc
added
the
interface
|
It should be safe to use |
|
That passes, so I'm going to merge this to get the code out there. Hopefully we won't see any uptick in crash-on-exit reports, but if we do we can always revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I screwed up. A while back, I connected PyQt5's
QApplication.aboutToQuitsignal to thedeleteLater()slot of the WebView, intending it to clean up just before shutdown.Turns out, PyQt5's implementation of QApplication emits that signal every time the user types anything on the input line, when running Python interactively, making the interactive shell essentially useless.
Merging this might bring back some crash-on-quit issues that the signal's destruction of the Timeline was preventing, but we should be able to find another solution. (Maybe connecting
QApplication.quitto the slot, instead ofaboutToQuit.)I also added a debug log in
OpenShotApp.cleanup(). It's connected toOpenShotApp.aboutToQuitas well, and I'm concerned the same issue could be causing excessive calls to that method, even though we can't see them.